All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Anholt <eric@anholt.net>
To: Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
Subject: Re: [RESEND PATCH] conf/cards: add VC4-HDMI card
Date: Thu, 16 Mar 2017 10:28:36 -0700	[thread overview]
Message-ID: <87fuidcerf.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <1488451773-22010-1-git-send-email-boris.brezillon@free-electrons.com>


[-- Attachment #1.1: Type: text/plain, Size: 1919 bytes --]

Boris Brezillon <boris.brezillon@free-electrons.com> writes:

> Add a conf file for the VC4-HDMI sound card.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
> Hi,
>
> Sorry for the noise, but I didn't send this patch to the alsa-lib
> maintainer on my first attempt.
>
> This patch is adding a card config file for the audio sound card whose
> driver has been submitted here [1] (not accepted yet).
>
> Since I am a total newbie to the alsa world, I'd like to get some
> feedback on this patch.
>
> Also, the card only supports 2 to 8 channels, and I wonder if we should
> add a plug element to support mono streams, and where this element
> should be added (after or before the iec958 element).
>
> Regards,
>
> Boris
>
> [1]https://www.spinics.net/lists/arm-kernel/msg565182.html

The kernel driver is getting merged now.

Tested-by: Eric Anholt <eric@anholt.net>

PulseAudio on the desktop seems to work fine.  aplay at the console
fails:

aplay -v  ~/LRMonoPhase4.wav
Playing WAVE '/home/anholt/LRMonoPhase4.wav' : Signed 16 bit Little Endian, Rate 48000 Hz, Stereo
aplay: set_params:1297: Sample format non available
Available formats:
- IEC958_SUBFRAME_LE

but if you specify iec958 it works:

aplay -v -D iec958  ~/LRMonoPhase4.wav 
Playing WAVE '/home/anholt/LRMonoPhase4.wav' : Signed 16 bit Little Endian, Rate 48000 Hz, Stereo
IEC958 subframe conversion PCM (IEC958_SUBFRAME_LE)
Its setup is:
  stream       : PLAYBACK
...

but if you specify a mono file it doesn't:

anholt@rpi-open:/home/anholt% aplay -v -D iec958  /usr/share/sounds/alsa/Front_Left.wav 
Playing WAVE '/usr/share/sounds/alsa/Front_Left.wav' : Signed 16 bit Little Endian, Rate 48000 Hz, Mono
aplay: set_params:1361: Unable to install hw params:
ACCESS:  RW_INTERLEAVED
FORMAT:  S16_LE
SUBFORMAT:  STD
SAMPLE_BITS: 16
FRAME_BITS: 16
CHANNELS: 1
...

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



  reply	other threads:[~2017-03-16 17:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-02 10:49 [RESEND PATCH] conf/cards: add VC4-HDMI card Boris Brezillon
2017-03-16 17:28 ` Eric Anholt [this message]
2017-03-20 11:06 ` Takashi Iwai
2017-04-06 19:46   ` Eric Anholt
2017-04-07  8:21     ` Takashi Iwai
2017-04-07 17:20       ` Eric Anholt
2017-04-10 12:09         ` Boris Brezillon
2017-04-10 12:19           ` Takashi Iwai
2017-04-10 12:35             ` Boris Brezillon
2017-04-10 12:42               ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fuidcerf.fsf@eliezer.anholt.net \
    --to=eric@anholt.net \
    --cc=alsa-devel@alsa-project.org \
    --cc=boris.brezillon@free-electrons.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.