From: Jani Nikula <jani.nikula@intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: distinguish G33 and Pineview from each other
Date: Thu, 08 Dec 2016 00:06:37 +0200 [thread overview]
Message-ID: <87fulzl7gy.fsf@intel.com> (raw)
In-Reply-To: <20161207211217.GX31595@intel.com>
On Wed, 07 Dec 2016, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> A lot of the checks involving g33 are apparently quite ugly. Might be
> nice to clean some of those up into a more readable form. But the
> patch looks correct so, and it looks like the rest of the IS_G33 checks
> already deal with PNV separately.
Agreed. But this is the required first step.
> I do wonder a bit about the IS_PINEVIEW_G and IS_PINEVIEW_M. I wonder if
> we should/could convert that to .is_mobile=true/false? Right now we seem
> to set .is_mobile=true for both.
Patches follow.
In the mean time, this one pushed, thanks for the review.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-12-07 22:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-07 20:48 [PATCH] drm/i915: distinguish G33 and Pineview from each other Jani Nikula
2016-12-07 21:12 ` Ville Syrjälä
2016-12-07 22:06 ` Jani Nikula [this message]
2016-12-07 21:15 ` ✗ Fi.CI.BAT: warning for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fulzl7gy.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.