From: Robert Jarzmik <robert.jarzmik@free.fr>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Marek Vasut" <marek.vasut@gmail.com>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
Richard Weinberger <richard@nod.at>,
linux-mtd@lists.infradead.org,
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
kernel@pengutronix.de
Subject: Re: [PATCH] mtd: nand: pxa3xx_nand: write exactly one message on probe failure
Date: Sat, 29 Oct 2016 21:59:18 +0200 [thread overview]
Message-ID: <87funf0vvt.fsf@belgarion.home> (raw)
In-Reply-To: <ac811aeb-1f9d-e985-134b-8faba0a1a4cf@gmail.com> (Marek Vasut's message of "Sat, 29 Oct 2016 19:56:39 +0200")
Marek Vasut <marek.vasut@gmail.com> writes:
> On 10/28/2016 10:04 AM, Boris Brezillon wrote:
>> On Mon, 19 Sep 2016 11:21:18 +0200
>> Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
>>
>>> For some error paths alloc_nand_resource() emitted an error message, for
>>> others it didn't. Make it consistently print a message including the
>>> error code where it's not constant and drop the hardly helpful
>>> additional message printed by the caller of alloc_nand_resource.
>>>
>>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>>
>> It looks good to me. Ezequiel, Robert, any objection to this patch? If
>> not, can I have your Acked/Reviewed-by ?
Hi,
Actually I was wondering if my mail system is utterly broken ... This is the
first mail I receive, while it seems to me I was in the recipients in the former
ones ...
You can take my Reviewed-by, at least from:
https://patchwork.ozlabs.org/patch/671644/
As a side note, normally for pxa architecture we use a printk format to display
the return value as :
pr_something("XXXX :%d\n", ret)
As pxa3xx_nand is shared with other architectures this will be Boris/Ezequiel's
call.
Cheers.
--
Robert
next prev parent reply other threads:[~2016-10-29 19:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 9:21 [PATCH] mtd: nand: pxa3xx_nand: write exactly one message on probe failure Uwe Kleine-König
2016-10-28 8:04 ` Boris Brezillon
2016-10-29 17:56 ` Marek Vasut
2016-10-29 19:07 ` Boris Brezillon
2016-10-29 19:59 ` Robert Jarzmik [this message]
2016-11-06 17:29 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87funf0vvt.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=boris.brezillon@free-electrons.com \
--cc=ezequiel.garcia@free-electrons.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=kernel@pengutronix.de \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.