All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Pranith Kumar <bobby.prani@gmail.com>,
	Richard Henderson <rth@twiddle.net>,
	qemu-devel <qemu-devel@nongnu.org>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [RFC PATCH 0/4] Clean up TCG tests
Date: Mon, 22 Aug 2016 10:19:14 +0100	[thread overview]
Message-ID: <87fupxw48d.fsf@linaro.org> (raw)
In-Reply-To: <CAFEAcA-JQV-kQ4zdS0J5Vpcr1zVU0FY6vB4ZqjosRyQ8gm9kzQ@mail.gmail.com>


Peter Maydell <peter.maydell@linaro.org> writes:

> On 21 August 2016 at 04:46, Pranith Kumar <bobby.prani@gmail.com> wrote:
>> The tests currently fail, so I didn't think it would be appropriate to
>> hook them up.  If the rearrangement is acceptable and once I fix the
>> tests, I will hook up 'make check' to run these tests.
>
> So the question is: how will this work on systems which
> don't have the relevant compiler toolchain for the target?
> This has always been the stumbling block for tests which
> want to run guest code: it's just too much of a pain for
> most developers to have the toolchains available to build
> the guest code.

We could just make running the tests optional on ./configure finding the
relevant cross compilers. The misc/ tests at the very least can be built
with the host compiler and run on a host-to-host linux-user build.

>
> I have a vague idea that we could use something involving
> docker images so that you could define a test case including
> what the toolchain it needed to build was, and then have
> images so that in practice you could just use prebuilt
> binaries for the test blobs. But I haven't really thought
> much about it yet.

Currently the docker support doesn't allow copying artefacts from the
build. But you can certainly run a make target in a (potentially)
cross arch docker container now. For example:

  make docker-test-quick@debian-bootstrap \
    EXTRA_CONFIGURE_OPTS="--enable-gprof --enable-gcov --disable-pie" \
    J=9 V=1 DEBUG=1

If we fix up make test to build misc + host compiler directory then they
will get run by the binfmt_misc enabled linux-user binary that was
copied when the image was created. You can update the image with the
current image easily enough:

  ./tests/docker/docker.py update qmu:debian-bootstrap ./arm-linux-user/qemu-arm

>
> thanks
> -- PMM


--
Alex Bennée

      reply	other threads:[~2016-08-22  9:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-19 17:00 [Qemu-devel] [RFC PATCH 0/4] Clean up TCG tests Pranith Kumar
2016-08-19 17:00 ` [Qemu-devel] [RFC PATCH 1/4] tests/tcg: Move i386 tests to arch specific folder Pranith Kumar
2016-08-19 17:00 ` [Qemu-devel] [RFC PATCH 2/4] tests/tcg: Move arm " Pranith Kumar
2016-08-19 17:00 ` [Qemu-devel] [RFC PATCH 3/4] tcg/tests: Move mips test " Pranith Kumar
2016-08-22  9:34   ` Alex Bennée
2016-08-22 14:38     ` Pranith Kumar
2016-08-19 17:00 ` [Qemu-devel] [RFC PATCH 4/4] tests/tcg: misc tests holds arch independent tests Pranith Kumar
2016-08-21  3:19 ` [Qemu-devel] [RFC PATCH 0/4] Clean up TCG tests Richard Henderson
2016-08-21  3:46   ` Pranith Kumar
2016-08-21 10:41     ` Peter Maydell
2016-08-22  9:19       ` Alex Bennée [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fupxw48d.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=bobby.prani@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.