From: Jani Nikula <jani.nikula@linux.intel.com>
To: Dave Gordon <david.s.gordon@intel.com>,
Chris Wilson <chris@chris-wilson.co.uk>,
intel-gfx@lists.freedesktop.org
Subject: Re: Polymorphic to_i915()
Date: Mon, 18 Apr 2016 14:49:26 +0300 [thread overview]
Message-ID: <87fuujp261.fsf@intel.com> (raw)
In-Reply-To: <5714C0CB.8030401@intel.com>
On Mon, 18 Apr 2016, Dave Gordon <david.s.gordon@intel.com> wrote:
> The GuC changes are OK, and we might as well convert "dev_priv" to
> "i915" at the same time, if that's now the preferred name.
Hmph, I see that "struct drm_i915_private *i915" is already being used
in a few places. This is more than a little confusing since "struct
i915_params i915" in i915_params.c is also the struct we currently use
to hold the module parameters. Rather annoyingly, there are no warnings
about the module wide i915 being shadowed.
I oppose to having both around. Please figure this out before adding a
single new "struct drm_i915_private *i915".
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-04-18 11:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-15 17:45 Polymorphic to_i915() Chris Wilson
2016-04-15 17:46 ` [PATCH 1/6] drm/i915: Rename the magic polymorphic macro __I915__ Chris Wilson
2016-04-20 14:27 ` Dave Gordon
2016-04-15 17:46 ` [PATCH 2/6] drm/i915: Allow passing any known pointer to for_each_engine() Chris Wilson
2016-04-15 17:46 ` [PATCH 3/6] drm/i915: Extend magic to_i915() to work with drm_i915_gem_object Chris Wilson
2016-04-15 17:46 ` [PATCH 4/6] drm/i915: Use to_i915() instead of guc_to_i915() Chris Wilson
2016-04-15 17:46 ` [PATCH 5/6] drm/i915: Teach to_i915() how to extract drm_i915_private from requests Chris Wilson
2016-04-15 17:46 ` [PATCH 6/6] drm/i915: Teach to_i915() how to extract drm_i915_private from engines Chris Wilson
2016-04-18 9:18 ` Polymorphic to_i915() Jani Nikula
2016-04-18 11:11 ` Dave Gordon
2016-04-18 11:49 ` Jani Nikula [this message]
2016-04-18 12:09 ` Chris Wilson
2016-04-20 12:57 ` Daniel Vetter
2016-04-20 14:29 ` Dave Gordon
2016-04-20 15:26 ` Mika Kuoppala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fuujp261.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=david.s.gordon@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.