From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZoVve-0006Gp-5c for ath10k@lists.infradead.org; Tue, 20 Oct 2015 12:22:10 +0000 From: Kalle Valo Subject: Re: [PATCH 1/5] ath10k: QCA988X hw2.0: add board.bin References: <1444905644-16296-1-git-send-email-kvalo@qca.qualcomm.com> <1445192636.31451.74.camel@decadent.org.uk> Date: Tue, 20 Oct 2015 15:21:30 +0300 In-Reply-To: <1445192636.31451.74.camel@decadent.org.uk> (Ben Hutchings's message of "Sun, 18 Oct 2015 19:23:56 +0100") Message-ID: <87fv15d92t.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Ben Hutchings Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, linux-firmware@kernel.org QmVuIEh1dGNoaW5ncyA8YmVuQGRlY2FkZW50Lm9yZy51az4gd3JpdGVzOgoKPiBPbiBUaHUsIDIw MTUtMTAtMTUgYXQgMTM6NDAgKzAzMDAsIEthbGxlIFZhbG8gd3JvdGU6Cj4+IEluIGNvbW1pdCA0 MGQxNDE0M2I3ODcgKCJhdGgxMGs6IGFkZCBmaXJtd2FyZSAxMC4yLjQuNDUgYXMgZmlybXdhcmUt NC5iaW4iKSBJCj4+IGZvcmdvdCB0byBjb21taXQgYm9hcmQuYmluIGZpbGUgYW5kIHRoYXQncyB3 aHkgaXQgd2FzIG5vdCBpbmNsdWRlZCBpbiB0aGUKPj4gY29tbWl0IGV2ZW4gSSBoYWQgYWRkZWQg YW4gZW50cnkgdG8gV0hFTkNFLiBBZGQgdGhhdCBub3cuCj4+IAo+PiBBdCB0aGUgc2FtZSB0aW1l IGFsc28gYWRkIFZlcnNpb24gZmllbGQgZm9yIGZpcm13YXJlLTQuYmluLgo+PiAKPj4gU2lnbmVk LW9mZi1ieTogS2FsbGUgVmFsbyA8a3ZhbG9AcWNhLnF1YWxjb21tLmNvbT4KPiBbLi4uXQo+Cj4g SSd2ZSBhcHBsaWVkIHRoaXMgYW5kIHRoZSBmb2xsb3dpbmcgNCBwYXRjaGVzLiDCoEhvd2V2ZXIs IEknbSBub3QKPiBlbnRpcmVseSBoYXBweSB3aXRoIGNvcHlyaWdodCBhY2tub3dsZWRnZW1lbnRz IGdvaW5nIGludG8gdGhlCj4gbm90aWNlX2F0aDEwayoudHh0IGZpbGVzIHdoaWNoIGFyZW4ndCBy ZWZlcmVuY2VkIGFueXdoZXJlLiDCoEl0IHdvdWxkIGJlCj4gZWFzeSBmb3IgZG93bnN0cmVhbSBk aXN0cmlidXRvcnMgdG8gbWlzcyB0aGF0IHRoZXkgc2hvdWxkIGJlIHBhY2thZ2VkCj4gYWxvbmcg d2l0aCB0aGUgZmlybXdhcmUgYmxvYnMgdGhleSByZWxhdGUgdG8uIMKgUGxlYXNlIGNhbiB5b3Ug Y29tYmluZQo+IHRoZXNlIHdpdGggdGhlIFFDQSBsaWNlbmNlIGZpbGUgb3IgYWRkIHJlZmVyZW5j ZXMgdG8gdGhlc2UgZmlsZXMgZnJvbQo+IFdIRU5DRT8KCkNvbWJpbmluZyB3aXRoIHRoZSBsaWNl bnNlIGZpbGUgaXMgZGlmZmljdWx0IGFzIHRoZSBub3RpY2UudHh0IGNhbiBiZQpkaWZmZXJlbnQg YmV0d2VlbiBmaXJtd2FyZSB2ZXJzaW9ucywgYnV0IEkgY2FuIGFkZCBhIHJlZmVyZW5jZSB0bwpX SEVOQ0UuIEkgZ3Vlc3MgeW91IG1lYW4gdG8gYWRkIGEgbmV3ICJGaWxlOiAiIGxpbmUgZm9yIGVh Y2ggLnR4dCBmaWxlPwoKLS0gCkthbGxlIFZhbG8KCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmF0aDEwayBtYWlsaW5nIGxpc3QKYXRoMTBrQGxpc3RzLmlu ZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9h dGgxMGsK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:37959 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751624AbbJTMVw convert rfc822-to-8bit (ORCPT ); Tue, 20 Oct 2015 08:21:52 -0400 From: Kalle Valo To: Ben Hutchings CC: , , Subject: Re: [PATCH 1/5] ath10k: QCA988X hw2.0: add board.bin References: <1444905644-16296-1-git-send-email-kvalo@qca.qualcomm.com> <1445192636.31451.74.camel@decadent.org.uk> Date: Tue, 20 Oct 2015 15:21:30 +0300 In-Reply-To: <1445192636.31451.74.camel@decadent.org.uk> (Ben Hutchings's message of "Sun, 18 Oct 2015 19:23:56 +0100") Message-ID: <87fv15d92t.fsf@kamboji.qca.qualcomm.com> (sfid-20151020_142156_436690_B19ECFDC) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Sender: linux-wireless-owner@vger.kernel.org List-ID: Ben Hutchings writes: > On Thu, 2015-10-15 at 13:40 +0300, Kalle Valo wrote: >> In commit 40d14143b787 ("ath10k: add firmware 10.2.4.45 as firmware-4.bin") I >> forgot to commit board.bin file and that's why it was not included in the >> commit even I had added an entry to WHENCE. Add that now. >> >> At the same time also add Version field for firmware-4.bin. >> >> Signed-off-by: Kalle Valo > [...] > > I've applied this and the following 4 patches.  However, I'm not > entirely happy with copyright acknowledgements going into the > notice_ath10k*.txt files which aren't referenced anywhere.  It would be > easy for downstream distributors to miss that they should be packaged > along with the firmware blobs they relate to.  Please can you combine > these with the QCA licence file or add references to these files from > WHENCE? Combining with the license file is difficult as the notice.txt can be different between firmware versions, but I can add a reference to WHENCE. I guess you mean to add a new "File: " line for each .txt file? -- Kalle Valo