From: "Bjørn Mork" <bjorn@mork.no>
To: Oliver Neukum <oneukum@suse.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH] usbnet: removed USB_USBNET as a config option
Date: Tue, 20 Oct 2015 13:03:22 +0200 [thread overview]
Message-ID: <87fv15u7id.fsf@nemi.mork.no> (raw)
In-Reply-To: <1445336670.2246.11.camel@suse.com> (Oliver Neukum's message of "Tue, 20 Oct 2015 12:24:30 +0200")
Oliver Neukum <oneukum@suse.com> writes:
> On Tue, 2015-10-20 at 10:43 +0200, Bjørn Mork wrote:
>
>> So we might need to move cdc_parse_cdc_header() out of usbnet.c after
>> all. Keeping it there creates an unnecessary "select" mess. But I don't
>> know where to put it... Either a common CDC helper module or the USB
>> core I guess.
>
> A common module means that the overhead of a module would be incurred.
> Do you have any other candidates that could go into a common helper
> module?
Not anything that matters. Some of the CDC notification handling could
maybe be shared by using a shoehorn on it, but I think that would make
the code less maintainable so it is not a good idea.
So, no, I don't have any other candidates. "usbcore" looks like the best
place for this function, if that is acceptable to Greg.
Bjørn
prev parent reply other threads:[~2015-10-20 11:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 12:23 [PATCH] usbnet: removed USB_USBNET as a config option Oliver Neukum
2015-10-19 19:16 ` Bjørn Mork
2015-10-20 6:28 ` Oliver Neukum
2015-10-20 8:43 ` Bjørn Mork
2015-10-20 10:24 ` Oliver Neukum
2015-10-20 11:03 ` Bjørn Mork [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fv15u7id.fsf@nemi.mork.no \
--to=bjorn@mork.no \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.