From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45272)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1ZoV4u-00007B-NG
	for qemu-devel@nongnu.org; Tue, 20 Oct 2015 07:27:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1ZoV4q-0005uh-NU
	for qemu-devel@nongnu.org; Tue, 20 Oct 2015 07:27:40 -0400
Received: from mx1.redhat.com ([209.132.183.28]:37091)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1ZoV4q-0005tz-IS
	for qemu-devel@nongnu.org; Tue, 20 Oct 2015 07:27:36 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <1443515898-3594-20-git-send-email-dgilbert@redhat.com> (David
	Alan Gilbert's message of "Tue, 29 Sep 2015 09:37:43 +0100")
References: <1443515898-3594-1-git-send-email-dgilbert@redhat.com>
	<1443515898-3594-20-git-send-email-dgilbert@redhat.com>
Date: Tue, 20 Oct 2015 13:27:31 +0200
Message-ID: <87fv15vkyk.fsf@neno.neno>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v8 19/54] Return path: Control commands
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: aarcange@redhat.com, liang.z.li@intel.com, qemu-devel@nongnu.org, luis@cs.umu.se, bharata@linux.vnet.ibm.com, amit.shah@redhat.com, pbonzini@redhat.com

"Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Add two src->dest commands:
>    * OPEN_RETURN_PATH - To request that the destination open the return path
>    * PING - Request an acknowledge from the destination
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Reviewed-by: Amit Shah <amit.shah@redhat.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>


> +void qemu_savevm_send_open_return_path(QEMUFile *f)
> +{
> +    qemu_savevm_command_send(f, MIG_CMD_OPEN_RETURN_PATH, 0, NULL);


For consistency, I would have put a

       trace_savevm_send_open_return_path(....) here

The send in the loadvm path