From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH for v4.2] Revert "drm/i915: Allow parsing of variable size child device entries from VBT" Date: Wed, 19 Aug 2015 11:40:21 +0300 Message-ID: <87fv3fd62y.fsf@intel.com> References: <1439890416-16826-1-git-send-email-jani.nikula@intel.com> <1439972274.3167.2.camel@sorvi> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id C32D26E4F7 for ; Wed, 19 Aug 2015 01:37:22 -0700 (PDT) In-Reply-To: <1439972274.3167.2.camel@sorvi> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: mika.kahola@intel.com, Daniel Vetter Cc: intel-gfx List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAxOSBBdWcgMjAxNSwgTWlrYSBLYWhvbGEgPG1pa2Eua2Fob2xhQGludGVsLmNvbT4g d3JvdGU6Cj4gT24gVHVlLCAyMDE1LTA4LTE4IGF0IDA5OjU4IC0wNzAwLCBEYW5pZWwgVmV0dGVy IHdyb3RlOgo+PiBPbiBUdWUsIEF1ZyAxOCwgMjAxNSBhdCAyOjMzIEFNLCBKYW5pIE5pa3VsYSA8 amFuaS5uaWt1bGFAaW50ZWwuY29tPiB3cm90ZToKPj4gPiBUaGlzIHJldmVydHMKPj4gPgo+PiA+ IGNvbW1pdCAwNDdmZTZlNmRiOTE2MWU2OTI3MWY1NmRhYWFmZGFmMmFkZDAyM2IxCj4+ID4gQXV0 aG9yOiBEYXZpZCBXZWluZWhhbGwgPGRhdmlkLndlaW5laGFsbEBsaW51eC5pbnRlbC5jb20+Cj4+ ID4gRGF0ZTogICBUdWUgQXVnIDQgMTY6NTU6NTIgMjAxNSArMDMwMAo+PiA+Cj4+ID4gICAgIGRy bS9pOTE1OiBBbGxvdyBwYXJzaW5nIG9mIHZhcmlhYmxlIHNpemUgY2hpbGQgZGV2aWNlIGVudHJp ZXMgZnJvbSBWQlQKPj4gPgo+PiA+IFRoYXQgY29tbWl0IGlzIG5vdCB2YWxpZCBmb3IgdjQuMiwg aG93ZXZlciBpdCB3aWxsIGJlIHZhbGlkIGZvciB2NC4zLiBJdAo+PiA+IHdhcyBzaW1wbHkgcXVl dWVkIHRvbyBlYXJseS4KPj4gCj4+IE5vcGUsIHRoaXMgcGF0Y2ggZnJvbSBEYXZpZCBhbHNvIGlu Y2lkZW50YWxseSBmaXhlcyBhIHJlZ3Jlc3Npb24gZnJvbQo+PiA5MGU0ZjE1OTJiYjZlODJmNjY5 MGYwZTA1YThhYWRjIHdoaWNoIGlzIHdoeSBJIG1lcmdlZCBpdCB0by4gSWYgeW91Cj4+IHdhbnQg dG8gcmV2ZXJ0IHRoaXMsIHlvdSBuZWVkIHRvIHJldmVydCBtb3JlIChhbmQgd2l0aCB0aGF0IGFs c28gYnJlYWsKPj4gQlNXKS4KPj4gCj4+IElzbid0IHRoZXJlIGEgbW9yZSBtaW5pbWFsIGZpeCB3 ZSBjYW4gZG8gZm9yIDQuMj8KPiBJIHByb3Bvc2VkIGEgdmVyeSBtaW5pbWFsIHNvbHV0aW9uIGp1 c3QgdG8gaW5jcmVhc2UgdGhlIHNpemUgb2YgdGhlIHJhdwo+IGJ1ZmZlciB0byB0aGUgbWF4aW11 bSBvZiAzOCBieXRlcyBzbyB3ZSBjb3VsZCBsYXRlciBvbiBwYXJzZSB0aGUgY29ycmVjdAo+IGlu Zm8uCgpUaGF0IGRvZXNuJ3Qgd29yayBiZWNhdXNlIGl0IGJyZWFrcyBwYXJzZV9zZHZvX2Rldmlj ZV9tYXBwaW5nKCkuIEkndmUKZml4ZWQgdGhpcyBub3cgaW4gZHJtLWludGVsLW5leHQtZml4ZXMg dG8gYmUgcXVldWVkIGZvciB2NC4zLCBidXQgSSBkbwpub3Qgd2FudCB0byBzdGFydCBwYXRjaGlu ZyB1cCBicm9rZW4gY29tbWl0cyBhdCB2NC4yLXJjNyBzdGFnZS4KCkFzIEkndmUgc2FpZCwgaWYg VmlsbGUncyBjb21taXQgOTBlNGYxNTkyYmI2IHJlYWxseSBkb2VzIGJyZWFrIHN0dWZmIGluCnY0 LjIgKCopLCBEYXZpZCdzIGNvbW1pdCAwNDdmZTZlNmRiOTEgZG9lcyBub3QgZml4IGl0IGluIHY0 LjIgYW55d2F5LgoKVGh1cyBJJ3ZlIGFwcGxpZWQgdGhlIHJldmVydC4gSXQgaXMgdGhlIG1pbmlt YWwgZml4LiB2NC4yIHdpbGwgYmUKZmluZS4gRm9yIHY0LjMgSSdsbCBuZWVkIHRvIG1ha2UgYSBi YWNrbWVyZ2UgZnJvbSBkcm0taW50ZWwtZml4ZXMgdG8KZHJtLWludGVsLW5leHQtZml4ZXMsIGFu ZCB3ZSBjYW4gbW92ZSBvbiB0byBmaXhpbmcgdjQuMy4KCkJSLApKYW5pLgoKCigqKSB3aGljaCBJ IGhpZ2hseSBkb3VidCBpbiB0aGUgZmlyc3QgcGxhY2U7IGxpa2VseSB0aGlzIHdhcyBzZWVuIGlu Ci1uaWdodGx5IGFuZCBlcnJvbmVvdXNseSBhdHRyaWJ1dGVkIGFzIGEgcmVncmVzc2lvbiBvbiA5 MGU0ZjE1OTJiYjYuCgoKCj4KPiBNYXkgbm90IGJlIHJlbGV2YW50IGFueW1vcmUKPgo+IGh0dHBz Oi8vYnVncy5mcmVlZGVza3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTkxMjY5Cj4KPiAtTWlrYS0K Pgo+PiAtRGFuaWVsCj4+IAo+PiA+Cj4+ID4gVGhlIHJlZmVyZW5jZWQgcmVncmVzc2luZyBjb21t aXQgaXMganVzdCBmaW5lIHVudGlsIHRoZSBzaXplIG9mIHN0cnVjdAo+PiA+IGNvbW1vbl9jaGls ZF9kZXZfY29uZmlnIGNoYW5nZXMsIGFuZCB0aGF0IHdvbid0IGhhcHBlbiB1bnRpbAo+PiA+IHY0 LjMuIEluZGVlZCwgdGhlIGV4cGVjdGVkIHNpemUgY2hlY2tzIGhlcmUgcmVseSBvbiB0aGUgaW5j cmVhc2VkIHNpemUKPj4gPiBvZiB0aGUgc3RydWN0LCBicmVha2luZyBuZXcgcGxhdGZvcm1zLgo+ PiA+Cj4+ID4gRml4ZXM6IDA0N2ZlNmU2ZGI5MSAoImRybS9pOTE1OiBBbGxvdyBwYXJzaW5nIG9m IHZhcmlhYmxlIHNpemUgY2hpbGQgZGV2aWNlIGVudHJpZXMgZnJvbSBWQlQiKQo+PiA+IENjOiBE YW5pZWwgVmV0dGVyIDxkYW5pZWxAZmZ3bGwuY2g+Cj4+ID4gQ2M6IERhdmlkIFdlaW5laGFsbCA8 ZGF2aWQud2VpbmVoYWxsQGxpbnV4LmludGVsLmNvbT4KPj4gPiBDYzogVmlsbGUgU3lyasOkbMOk IDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPj4gPiBTaWduZWQtb2ZmLWJ5OiBKYW5p IE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+PiA+Cj4+ID4gLS0tCj4+ID4KPj4gPiBU aGVyZSB3YXMgYW5vdGhlciBwYXRjaCBmcm9tIERhdmlkIGluY3JlYXNpbmcgdGhlIHNpemUgb2Yg dGhlIHN0cnVjdAo+PiA+IFsxXSwgYnV0IHRoYXQgdGhlbiByZWdyZXNzZXMgc2R2byBtYXBwaW5n IHBhcnNpbmcuIEl0J3MgdGhlIHNpbXBsZXN0IHRvCj4+ID4ganVzdCByZXZlcnQgYW5kIGZpeCB0 aGlzIHVwIHByb3Blcmx5IGZvciB2NC4zLgo+PiA+Cj4+ID4gWzFdIGh0dHA6Ly9taWQuZ21hbmUu b3JnLzIwMTUwODEzMTMxNDE1LkdPNjE1MEBib29tCj4+ID4gLS0tCj4+ID4gIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2Jpb3MuYyB8IDI3ICsrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ PiA+ICAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCAyMyBkZWxldGlvbnMoLSkKPj4g Pgo+PiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9iaW9zLmMgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9iaW9zLmMKPj4gPiBpbmRleCAzZGNkNTllNjk0ZGIu LjE5OGZjM2MzMjkxYiAxMDA2NDQKPj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9iaW9zLmMKPj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9iaW9zLmMKPj4g PiBAQCAtMTA3NSwzNCArMTA3NSwxNSBAQCBwYXJzZV9kZXZpY2VfbWFwcGluZyhzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4+ID4gICAgICAgICBjb25zdCB1bmlvbiBjaGlsZF9k ZXZpY2VfY29uZmlnICpwX2NoaWxkOwo+PiA+ICAgICAgICAgdW5pb24gY2hpbGRfZGV2aWNlX2Nv bmZpZyAqY2hpbGRfZGV2X3B0cjsKPj4gPiAgICAgICAgIGludCBpLCBjaGlsZF9kZXZpY2VfbnVt LCBjb3VudDsKPj4gPiAtICAgICAgIHU4IGV4cGVjdGVkX3NpemU7Cj4+ID4gLSAgICAgICB1MTYg YmxvY2tfc2l6ZTsKPj4gPiArICAgICAgIHUxNiAgICAgYmxvY2tfc2l6ZTsKPj4gPgo+PiA+ICAg ICAgICAgcF9kZWZzID0gZmluZF9zZWN0aW9uKGJkYiwgQkRCX0dFTkVSQUxfREVGSU5JVElPTlMp Owo+PiA+ICAgICAgICAgaWYgKCFwX2RlZnMpIHsKPj4gPiAgICAgICAgICAgICAgICAgRFJNX0RF QlVHX0tNUygiTm8gZ2VuZXJhbCBkZWZpbml0aW9uIGJsb2NrIGlzIGZvdW5kLCBubyBkZXZpY2Vz IGRlZmluZWQuXG4iKTsKPj4gPiAgICAgICAgICAgICAgICAgcmV0dXJuOwo+PiA+ICAgICAgICAg fQo+PiA+IC0gICAgICAgaWYgKGJkYi0+dmVyc2lvbiA8IDE5NSkgewo+PiA+IC0gICAgICAgICAg ICAgICBleHBlY3RlZF9zaXplID0gMzM7Cj4+ID4gLSAgICAgICB9IGVsc2UgaWYgKGJkYi0+dmVy c2lvbiA9PSAxOTUpIHsKPj4gPiAtICAgICAgICAgICAgICAgZXhwZWN0ZWRfc2l6ZSA9IDM3Owo+ PiA+IC0gICAgICAgfSBlbHNlIGlmIChiZGItPnZlcnNpb24gPD0gMTk3KSB7Cj4+ID4gLSAgICAg ICAgICAgICAgIGV4cGVjdGVkX3NpemUgPSAzODsKPj4gPiAtICAgICAgIH0gZWxzZSB7Cj4+ID4g LSAgICAgICAgICAgICAgIGV4cGVjdGVkX3NpemUgPSAzODsKPj4gPiAtICAgICAgICAgICAgICAg RFJNX0RFQlVHX0RSSVZFUigiRXhwZWN0ZWQgY2hpbGRfZGV2aWNlX2NvbmZpZyBzaXplIGZvciBC REIgdmVyc2lvbiAldSBub3Qga25vd247IGFzc3VtaW5nICV1XG4iLAo+PiA+IC0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGV4cGVjdGVkX3NpemUsIGJkYi0+dmVyc2lvbik7Cj4+ID4g LSAgICAgICB9Cj4+ID4gLQo+PiA+IC0gICAgICAgaWYgKGV4cGVjdGVkX3NpemUgPiBzaXplb2Yo KnBfY2hpbGQpKSB7Cj4+ID4gLSAgICAgICAgICAgICAgIERSTV9FUlJPUigiY2hpbGRfZGV2aWNl X2NvbmZpZyBjYW5ub3QgZml0IGluIHBfY2hpbGRcbiIpOwo+PiA+IC0gICAgICAgICAgICAgICBy ZXR1cm47Cj4+ID4gLSAgICAgICB9Cj4+ID4gLQo+PiA+IC0gICAgICAgaWYgKHBfZGVmcy0+Y2hp bGRfZGV2X3NpemUgIT0gZXhwZWN0ZWRfc2l6ZSkgewo+PiA+IC0gICAgICAgICAgICAgICBEUk1f RVJST1IoIlNpemUgbWlzbWF0Y2g7IGNoaWxkX2RldmljZV9jb25maWcgc2l6ZT0ldSAoZXhwZWN0 ZWQgJXUpOyBiZGItPnZlcnNpb246ICV1XG4iLAo+PiA+IC0gICAgICAgICAgICAgICAgICAgICAg ICAgcF9kZWZzLT5jaGlsZF9kZXZfc2l6ZSwgZXhwZWN0ZWRfc2l6ZSwgYmRiLT52ZXJzaW9uKTsK Pj4gPiArICAgICAgIGlmIChwX2RlZnMtPmNoaWxkX2Rldl9zaXplIDwgc2l6ZW9mKCpwX2NoaWxk KSkgewo+PiA+ICsgICAgICAgICAgICAgICBEUk1fRVJST1IoIkdlbmVyYWwgZGVmaW5pdG9uIGJs b2NrIGNoaWxkIGRldmljZSBzaXplIGlzIHRvbyBzbWFsbC5cbiIpOwo+PiA+ICAgICAgICAgICAg ICAgICByZXR1cm47Cj4+ID4gICAgICAgICB9Cj4+ID4gICAgICAgICAvKiBnZXQgdGhlIGJsb2Nr IHNpemUgb2YgZ2VuZXJhbCBkZWZpbml0aW9ucyAqLwo+PiA+IEBAIC0xMTQ5LDcgKzExMzAsNyBA QCBwYXJzZV9kZXZpY2VfbWFwcGluZyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYs Cj4+ID4KPj4gPiAgICAgICAgICAgICAgICAgY2hpbGRfZGV2X3B0ciA9IGRldl9wcml2LT52YnQu Y2hpbGRfZGV2ICsgY291bnQ7Cj4+ID4gICAgICAgICAgICAgICAgIGNvdW50Kys7Cj4+ID4gLSAg ICAgICAgICAgICAgIG1lbWNweShjaGlsZF9kZXZfcHRyLCBwX2NoaWxkLCBwX2RlZnMtPmNoaWxk X2Rldl9zaXplKTsKPj4gPiArICAgICAgICAgICAgICAgbWVtY3B5KGNoaWxkX2Rldl9wdHIsIHBf Y2hpbGQsIHNpemVvZigqcF9jaGlsZCkpOwo+PiA+ICAgICAgICAgfQo+PiA+ICAgICAgICAgcmV0 dXJuOwo+PiA+ICB9Cj4+ID4gLS0KPj4gPiAyLjEuNAo+PiA+Cj4+IAo+PiAKPj4gCj4KPgoKLS0g CkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGlu ZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=