From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH for v4.2] Revert "drm/i915: Allow parsing of variable size child device entries from VBT" Date: Wed, 19 Aug 2015 05:34:31 +0300 Message-ID: <87fv3g9fbc.fsf@intel.com> References: <1439890416-16826-1-git-send-email-jani.nikula@intel.com> <20150818170040.GL5176@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 6D85B6E3DC for ; Tue, 18 Aug 2015 19:34:36 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter , Ville =?utf-8?B?U3lyasOkbMOk?= Cc: intel-gfx List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAxOSBBdWcgMjAxNSwgRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPiB3cm90 ZToKPiBPbiBUdWUsIEF1ZyAxOCwgMjAxNSBhdCAxMDowMCBBTSwgVmlsbGUgU3lyasOkbMOkCj4g PHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPiB3cm90ZToKPj4gT24gVHVlLCBBdWcgMTgs IDIwMTUgYXQgMDk6NTg6NTdBTSAtMDcwMCwgRGFuaWVsIFZldHRlciB3cm90ZToKPj4+IE9uIFR1 ZSwgQXVnIDE4LCAyMDE1IGF0IDI6MzMgQU0sIEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRl bC5jb20+IHdyb3RlOgo+Pj4gPiBUaGlzIHJldmVydHMKPj4+ID4KPj4+ID4gY29tbWl0IDA0N2Zl NmU2ZGI5MTYxZTY5MjcxZjU2ZGFhYWZkYWYyYWRkMDIzYjEKPj4+ID4gQXV0aG9yOiBEYXZpZCBX ZWluZWhhbGwgPGRhdmlkLndlaW5laGFsbEBsaW51eC5pbnRlbC5jb20+Cj4+PiA+IERhdGU6ICAg VHVlIEF1ZyA0IDE2OjU1OjUyIDIwMTUgKzAzMDAKPj4+ID4KPj4+ID4gICAgIGRybS9pOTE1OiBB bGxvdyBwYXJzaW5nIG9mIHZhcmlhYmxlIHNpemUgY2hpbGQgZGV2aWNlIGVudHJpZXMgZnJvbSBW QlQKPj4+ID4KPj4+ID4gVGhhdCBjb21taXQgaXMgbm90IHZhbGlkIGZvciB2NC4yLCBob3dldmVy IGl0IHdpbGwgYmUgdmFsaWQgZm9yIHY0LjMuIEl0Cj4+PiA+IHdhcyBzaW1wbHkgcXVldWVkIHRv byBlYXJseS4KPj4+Cj4+PiBOb3BlLCB0aGlzIHBhdGNoIGZyb20gRGF2aWQgYWxzbyBpbmNpZGVu dGFsbHkgZml4ZXMgYSByZWdyZXNzaW9uIGZyb20KPj4+IDkwZTRmMTU5MmJiNmU4MmY2NjkwZjBl MDVhOGFhZGMgd2hpY2ggaXMgd2h5IEkgbWVyZ2VkIGl0IHRvLgo+Pgo+PiBXaGF0IHJlZ3Jlc3Np b24/Cj4KPiBRdW90aW5nIHRoZSBjb21taXQgbWVzc2FnZTogIi4uLiAgc2luY2Ugd2UncmUgaGl0 dGluZyBhIERSTV9FUlJPUiBvbgo+IG9sZGVyIHBsYXRmb3JtcyB3aXRoIHRoaXMuIiBOb3QgZXZl cnkgcGxhdGZvcm0gaGFzIHRoZSBCU1cgdmJ0IGxheW91dAo+IDstKSBPaCBhbmQgd2h5IGRvIEkg ZXZlbiBib3RoZXIgdG8gd3JpdGUgdGhpcyBzdHVmZiB3aGVuIG5vIG9uZSByZWFkcwo+IGl0PwoK SSByZWFkIGl0LCBhbmQgSSB0aGluayBpdCdzIHdyb25nLiBJIGV2ZW4gZXhwbGFpbmVkIHdoeSBp biBteSBjb21taXQKbWVzc2FnZSAoeWVzLCBwbGVhc2UgcmVhZCBpdCkuIEkgZG9uJ3QgdGhpbmsg dGhlcmUgd2FzIGEgRFJNX0VSUk9SIG9uCm9sZGVyIHBsYXRmb3JtIHdpdGggVmlsbGUncyBwYXRj aCwgb24gdjQuMiB3aGVyZSB0aGUgcmV2ZXJ0IGlzIHRhcmdldGVkLAphbmQgZXZlbiBpZiB0aGVy ZSB3ZXJlLCBEYXZpZCdzIHBhdGNoIHdvdWxkICpub3QqIGZpeCBpdC4gSW5kZWVkIHRoZXJlCndh cyBubyBkaXNjdXNzaW9uIG9mIGEgcmVncmVzc2lvbiBvbiB0aGUgbWFpbGluZyBsaXN0LgoKSWYg dGhlcmUgd2FzIGFueSByZWdyZXNzaW9uLCBpdCB3YXMgaW50cm9kdWNlZCBieQoKY29tbWl0IDc1 MDY3ZGRlY2YyMTI3MTYzMWJjMDE4ZDJmYjIzZGRkMDliNjZhYWUKQXV0aG9yOiBBbnR0aSBLb3Nr aXBhYSA8YW50dGkua29za2lwYWFAbGludXguaW50ZWwuY29tPgpEYXRlOiAgIEZyaSBKdWwgMTAg MTQ6MTA6NTUgMjAxNSArMDMwMAoKICAgIGRybS9pOTE1OiBQZXItRERJIElfYm9vc3Qgb3ZlcnJp ZGUKCndoZW4gdGhlIHNpemUgb2YgdW5pb24gY2hpbGRfZGV2aWNlX2NvbmZpZyBjaGFuZ2VkLiBC dXQgdGhhdCdzIGhlYWRlZApmb3IgdjQuMy4gQW5kIHdlJ3JlIHRhbGtpbmcgYWJvdXQgdjQuMiwg d2hpY2ggaXMgZ2V0dGluZyBwcmV0dHkKdXJnZW50LiBXZSdsbCBoYXZlIGEgYml0IG1vcmUgdGlt ZSB0byBzb3J0IG91dCB0aGUgbWVzcyB0aGF0IHdpbGwgbGFuZAppbiB2NC4zIChhbmQgSSd2ZSBh bHJlYWR5IHNlbnQgb25lIHBhdGNoIHNvcnRpbmcgb3V0IFNEVk8gYnJlYWthZ2UpLgoKQlIsCkph bmkuCgoKCj4gLURhbmllbAo+Cj4+PiBJZiB5b3UKPj4+IHdhbnQgdG8gcmV2ZXJ0IHRoaXMsIHlv dSBuZWVkIHRvIHJldmVydCBtb3JlIChhbmQgd2l0aCB0aGF0IGFsc28gYnJlYWsKPj4+IEJTVyku Cj4+Pgo+Pj4gSXNuJ3QgdGhlcmUgYSBtb3JlIG1pbmltYWwgZml4IHdlIGNhbiBkbyBmb3IgNC4y Pwo+Pj4gLURhbmllbAo+Pj4KPj4+ID4KPj4+ID4gVGhlIHJlZmVyZW5jZWQgcmVncmVzc2luZyBj b21taXQgaXMganVzdCBmaW5lIHVudGlsIHRoZSBzaXplIG9mIHN0cnVjdAo+Pj4gPiBjb21tb25f Y2hpbGRfZGV2X2NvbmZpZyBjaGFuZ2VzLCBhbmQgdGhhdCB3b24ndCBoYXBwZW4gdW50aWwKPj4+ ID4gdjQuMy4gSW5kZWVkLCB0aGUgZXhwZWN0ZWQgc2l6ZSBjaGVja3MgaGVyZSByZWx5IG9uIHRo ZSBpbmNyZWFzZWQgc2l6ZQo+Pj4gPiBvZiB0aGUgc3RydWN0LCBicmVha2luZyBuZXcgcGxhdGZv cm1zLgo+Pj4gPgo+Pj4gPiBGaXhlczogMDQ3ZmU2ZTZkYjkxICgiZHJtL2k5MTU6IEFsbG93IHBh cnNpbmcgb2YgdmFyaWFibGUgc2l6ZSBjaGlsZCBkZXZpY2UgZW50cmllcyBmcm9tIFZCVCIpCj4+ PiA+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWxAZmZ3bGwuY2g+Cj4+PiA+IENjOiBEYXZpZCBX ZWluZWhhbGwgPGRhdmlkLndlaW5laGFsbEBsaW51eC5pbnRlbC5jb20+Cj4+PiA+IENjOiBWaWxs ZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+Pj4gPiBTaWduZWQt b2ZmLWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+Pj4gPgo+Pj4gPiAt LS0KPj4+ID4KPj4+ID4gVGhlcmUgd2FzIGFub3RoZXIgcGF0Y2ggZnJvbSBEYXZpZCBpbmNyZWFz aW5nIHRoZSBzaXplIG9mIHRoZSBzdHJ1Y3QKPj4+ID4gWzFdLCBidXQgdGhhdCB0aGVuIHJlZ3Jl c3NlcyBzZHZvIG1hcHBpbmcgcGFyc2luZy4gSXQncyB0aGUgc2ltcGxlc3QgdG8KPj4+ID4ganVz dCByZXZlcnQgYW5kIGZpeCB0aGlzIHVwIHByb3Blcmx5IGZvciB2NC4zLgo+Pj4gPgo+Pj4gPiBb MV0gaHR0cDovL21pZC5nbWFuZS5vcmcvMjAxNTA4MTMxMzE0MTUuR082MTUwQGJvb20KPj4+ID4g LS0tCj4+PiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9iaW9zLmMgfCAyNyArKysrLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0KPj4+ID4gIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMo KyksIDIzIGRlbGV0aW9ucygtKQo+Pj4gPgo+Pj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfYmlvcy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYmlvcy5j Cj4+PiA+IGluZGV4IDNkY2Q1OWU2OTRkYi4uMTk4ZmMzYzMyOTFiIDEwMDY0NAo+Pj4gPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9iaW9zLmMKPj4+ID4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfYmlvcy5jCj4+PiA+IEBAIC0xMDc1LDM0ICsxMDc1LDE1IEBAIHBh cnNlX2RldmljZV9tYXBwaW5nKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPj4+ ID4gICAgICAgICBjb25zdCB1bmlvbiBjaGlsZF9kZXZpY2VfY29uZmlnICpwX2NoaWxkOwo+Pj4g PiAgICAgICAgIHVuaW9uIGNoaWxkX2RldmljZV9jb25maWcgKmNoaWxkX2Rldl9wdHI7Cj4+PiA+ ICAgICAgICAgaW50IGksIGNoaWxkX2RldmljZV9udW0sIGNvdW50Owo+Pj4gPiAtICAgICAgIHU4 IGV4cGVjdGVkX3NpemU7Cj4+PiA+IC0gICAgICAgdTE2IGJsb2NrX3NpemU7Cj4+PiA+ICsgICAg ICAgdTE2ICAgICBibG9ja19zaXplOwo+Pj4gPgo+Pj4gPiAgICAgICAgIHBfZGVmcyA9IGZpbmRf c2VjdGlvbihiZGIsIEJEQl9HRU5FUkFMX0RFRklOSVRJT05TKTsKPj4+ID4gICAgICAgICBpZiAo IXBfZGVmcykgewo+Pj4gPiAgICAgICAgICAgICAgICAgRFJNX0RFQlVHX0tNUygiTm8gZ2VuZXJh bCBkZWZpbml0aW9uIGJsb2NrIGlzIGZvdW5kLCBubyBkZXZpY2VzIGRlZmluZWQuXG4iKTsKPj4+ ID4gICAgICAgICAgICAgICAgIHJldHVybjsKPj4+ID4gICAgICAgICB9Cj4+PiA+IC0gICAgICAg aWYgKGJkYi0+dmVyc2lvbiA8IDE5NSkgewo+Pj4gPiAtICAgICAgICAgICAgICAgZXhwZWN0ZWRf c2l6ZSA9IDMzOwo+Pj4gPiAtICAgICAgIH0gZWxzZSBpZiAoYmRiLT52ZXJzaW9uID09IDE5NSkg ewo+Pj4gPiAtICAgICAgICAgICAgICAgZXhwZWN0ZWRfc2l6ZSA9IDM3Owo+Pj4gPiAtICAgICAg IH0gZWxzZSBpZiAoYmRiLT52ZXJzaW9uIDw9IDE5Nykgewo+Pj4gPiAtICAgICAgICAgICAgICAg ZXhwZWN0ZWRfc2l6ZSA9IDM4Owo+Pj4gPiAtICAgICAgIH0gZWxzZSB7Cj4+PiA+IC0gICAgICAg ICAgICAgICBleHBlY3RlZF9zaXplID0gMzg7Cj4+PiA+IC0gICAgICAgICAgICAgICBEUk1fREVC VUdfRFJJVkVSKCJFeHBlY3RlZCBjaGlsZF9kZXZpY2VfY29uZmlnIHNpemUgZm9yIEJEQiB2ZXJz aW9uICV1IG5vdCBrbm93bjsgYXNzdW1pbmcgJXVcbiIsCj4+PiA+IC0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGV4cGVjdGVkX3NpemUsIGJkYi0+dmVyc2lvbik7Cj4+PiA+IC0gICAg ICAgfQo+Pj4gPiAtCj4+PiA+IC0gICAgICAgaWYgKGV4cGVjdGVkX3NpemUgPiBzaXplb2YoKnBf Y2hpbGQpKSB7Cj4+PiA+IC0gICAgICAgICAgICAgICBEUk1fRVJST1IoImNoaWxkX2RldmljZV9j b25maWcgY2Fubm90IGZpdCBpbiBwX2NoaWxkXG4iKTsKPj4+ID4gLSAgICAgICAgICAgICAgIHJl dHVybjsKPj4+ID4gLSAgICAgICB9Cj4+PiA+IC0KPj4+ID4gLSAgICAgICBpZiAocF9kZWZzLT5j aGlsZF9kZXZfc2l6ZSAhPSBleHBlY3RlZF9zaXplKSB7Cj4+PiA+IC0gICAgICAgICAgICAgICBE Uk1fRVJST1IoIlNpemUgbWlzbWF0Y2g7IGNoaWxkX2RldmljZV9jb25maWcgc2l6ZT0ldSAoZXhw ZWN0ZWQgJXUpOyBiZGItPnZlcnNpb246ICV1XG4iLAo+Pj4gPiAtICAgICAgICAgICAgICAgICAg ICAgICAgIHBfZGVmcy0+Y2hpbGRfZGV2X3NpemUsIGV4cGVjdGVkX3NpemUsIGJkYi0+dmVyc2lv bik7Cj4+PiA+ICsgICAgICAgaWYgKHBfZGVmcy0+Y2hpbGRfZGV2X3NpemUgPCBzaXplb2YoKnBf Y2hpbGQpKSB7Cj4+PiA+ICsgICAgICAgICAgICAgICBEUk1fRVJST1IoIkdlbmVyYWwgZGVmaW5p dG9uIGJsb2NrIGNoaWxkIGRldmljZSBzaXplIGlzIHRvbyBzbWFsbC5cbiIpOwo+Pj4gPiAgICAg ICAgICAgICAgICAgcmV0dXJuOwo+Pj4gPiAgICAgICAgIH0KPj4+ID4gICAgICAgICAvKiBnZXQg dGhlIGJsb2NrIHNpemUgb2YgZ2VuZXJhbCBkZWZpbml0aW9ucyAqLwo+Pj4gPiBAQCAtMTE0OSw3 ICsxMTMwLDcgQEAgcGFyc2VfZGV2aWNlX21hcHBpbmcoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2LAo+Pj4gPgo+Pj4gPiAgICAgICAgICAgICAgICAgY2hpbGRfZGV2X3B0ciA9IGRl dl9wcml2LT52YnQuY2hpbGRfZGV2ICsgY291bnQ7Cj4+PiA+ICAgICAgICAgICAgICAgICBjb3Vu dCsrOwo+Pj4gPiAtICAgICAgICAgICAgICAgbWVtY3B5KGNoaWxkX2Rldl9wdHIsIHBfY2hpbGQs IHBfZGVmcy0+Y2hpbGRfZGV2X3NpemUpOwo+Pj4gPiArICAgICAgICAgICAgICAgbWVtY3B5KGNo aWxkX2Rldl9wdHIsIHBfY2hpbGQsIHNpemVvZigqcF9jaGlsZCkpOwo+Pj4gPiAgICAgICAgIH0K Pj4+ID4gICAgICAgICByZXR1cm47Cj4+PiA+ICB9Cj4+PiA+IC0tCj4+PiA+IDIuMS40Cj4+PiA+ Cj4+Pgo+Pj4KPj4+Cj4+PiAtLQo+Pj4gRGFuaWVsIFZldHRlcgo+Pj4gU29mdHdhcmUgRW5naW5l ZXIsIEludGVsIENvcnBvcmF0aW9uCj4+PiArNDEgKDApIDc5IDM2NSA1NyA0OCAtIGh0dHA6Ly9i bG9nLmZmd2xsLmNoCj4+Cj4+IC0tCj4+IFZpbGxlIFN5cmrDpGzDpAo+PiBJbnRlbCBPVEMKPgo+ Cj4KPiAtLSAKPiBEYW5pZWwgVmV0dGVyCj4gU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBv cmF0aW9uCj4gKzQxICgwKSA3OSAzNjUgNTcgNDggLSBodHRwOi8vYmxvZy5mZndsbC5jaAoKLS0g CkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGlu ZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=