All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Jakub Kicinski <moorray3@wp.pl>
Cc: Johannes Berg <johannes@sipsolutions.net>,
	Felix Fietkau <nbd@openwrt.org>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	Jakub Kicinski <kubakici@wp.pl>
Subject: Re: [PATCHv2 0/2] add mt7601u driver
Date: Mon, 25 May 2015 11:13:32 +0300	[thread overview]
Message-ID: <87fv6l3wib.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1430857363-30844-1-git-send-email-moorray3@wp.pl> (Jakub Kicinski's message of "Tue, 5 May 2015 22:22:41 +0200")

Jakub Kicinski <moorray3@wp.pl> writes:

> From: Jakub Kicinski <kubakici@wp.pl>
>
>> This miniseries adds support for the simplest of MediaTek Wi-Fi
>> devices.  MT7601U is a single stream bgn chip with no bells or whistles.
>> My driver is partially based on Felix's mt76 but IMHO it doesn't
>> make sense to merge the two right now because MT7601U is a design
>> somewhere between old Ralink devices and new Mediatek chips.  There
>> wouldn't be all that much code sharing with the devices mt76 supports.
>> Situation may obviously change when someone decides to extend m76 with
>> support for the more recent USB dongles.
>> 
>> The driver supports only station mode.  I'm hoping to add AP support
>> when time allows.
>> 
>> This driver sat on GitHub for quite a while and got some testing there.
>> If anyone is interested in full git history and such here's a link:
>> 
>> http://github.com/kuba-moo/mt7601u
>> 
>> I split the submission into the build things and meta data (kconfig,
>> Makefiles, MAINTAINERS update etc.) and the actual code to make the
>> reviewing a little easier.
>
> v2:
>  - don't zero parts of just allocated skb (Johannes)
>  - add delay to polling of MAC state (Johannes)
>  - use paged RX (Johannes)
>  - add more device IDs (Jose)
>  - reduce number of RX buffers
>  - increase max length of USB dma aggregate

It doens't compile anymore due to a mac80211 change. Can you rebase,
please?

drivers/net/wireless/mediatek/mt7601u/main.c: In function 'mt76_configure_filter':
drivers/net/wireless/mediatek/mt7601u/main.c:122:31: error: 'FIF_PROMISC_IN_BSS' undeclared (first use in this function)
drivers/net/wireless/mediatek/mt7601u/main.c:122:31: note: each undeclared identifier is reported only once for each function it appears in

-- 
Kalle Valo

  parent reply	other threads:[~2015-05-25  8:13 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-02 13:01 [PATCH 0/2] add mt7601u driver moorray3
2015-05-02 13:01 ` [PATCH 1/2] " moorray3
2015-05-04  9:37   ` Johannes Berg
2015-05-04 10:04     ` Jakub Kiciński
2015-05-04 10:15       ` Johannes Berg
2015-05-05  0:49         ` Jakub Kiciński
2015-05-05  6:45           ` Johannes Berg
2015-05-05 10:44             ` Jakub Kiciński
2015-05-02 13:01 ` [PATCH 2/2] add mt7601u build infrastructure and co moorray3
2015-05-05 20:22 ` [PATCHv2 0/2] add mt7601u driver Jakub Kicinski
2015-05-05 20:22   ` [PATCHv2 1/2] " Jakub Kicinski
2015-05-05 20:22   ` [PATCHv2 2/2] add mt7601u kbuild and others Jakub Kicinski
2015-05-25  8:13   ` Kalle Valo [this message]
2015-05-25  9:35     ` [PATCHv2 0/2] add mt7601u driver Jakub Kiciński
2015-05-26  7:16       ` Johannes Berg
2015-05-25  9:34 ` [PATCHv3 " Jakub Kicinski
2015-05-25  9:34   ` [PATCHv3 1/2] " Jakub Kicinski
2015-05-25  9:34   ` [PATCHv3 2/2] add mt7601u kbuild and others Jakub Kicinski
2015-05-26 10:26   ` [PATCHv3 0/2] add mt7601u driver Kalle Valo
2015-05-26  9:16 ` [PATCHv4] " Jakub Kicinski
2015-05-28  8:36   ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fv6l3wib.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@codeaurora.org \
    --cc=johannes@sipsolutions.net \
    --cc=kubakici@wp.pl \
    --cc=linux-wireless@vger.kernel.org \
    --cc=moorray3@wp.pl \
    --cc=nbd@openwrt.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.