From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Nicolas Pitre <nico@fluxnic.net>,
"David S. Miller" <davem@davemloft.net>,
"netdev\@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Revert "smc91x: retrieve IRQ and trigger flags in a modern way"
Date: Fri, 13 Feb 2015 09:12:29 +0100 [thread overview]
Message-ID: <87fvaa5ixe.fsf@free.fr> (raw)
In-Reply-To: <CACRpkdZGze_2=hWe414Eum_9hpNXgog5vmu6Y4R_zhg0x2z0SQ@mail.gmail.com> (Linus Walleij's message of "Fri, 13 Feb 2015 10:16:09 +0800")
Linus Walleij <linus.walleij@linaro.org> writes:
> On Fri, Feb 13, 2015 at 12:59 AM, Robert Jarzmik <robert.jarzmik@free.fr> wrote:
> But isn't the real problem that in the device tree case,
> irq_get_irq_data(ndev->irq) will work becaus parsing an interrupt
> from the device tree populates it correctly in platform_get_irq()
> whereas for the legacy lookup it just fetches the number.
>
> So to me it seems like a weakness in the platform_get_irq()
> helper altogether.
>
> Does the following work? (I can send as a separate patch for
> testing if you like).
I will test this evening (GMT+1 time), I feel this will work, and that this
solution looks better to me than the sheer revert. I don't ask for a separate
patch, yet if it is confirmed that it works, you'll have to submit it anyway :)
Cheers.
--
Robert
next prev parent reply other threads:[~2015-02-13 8:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 16:59 [PATCH] Revert "smc91x: retrieve IRQ and trigger flags in a modern way" Robert Jarzmik
2015-02-13 2:16 ` Linus Walleij
2015-02-13 8:12 ` Robert Jarzmik [this message]
2015-02-13 16:06 ` Robert Jarzmik
2015-02-19 20:28 ` David Miller
2015-02-19 20:48 ` Robert Jarzmik
2015-02-19 21:22 ` David Miller
2015-03-16 21:06 ` Robert Jarzmik
2015-03-17 19:05 ` David Miller
2015-05-04 13:18 ` Linus Walleij
2015-05-04 19:13 ` David Miller
2015-02-20 9:37 ` Linus Walleij
2015-02-20 15:33 ` Greg KH
2015-02-23 15:14 ` Linus Walleij
2015-02-13 16:08 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvaa5ixe.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=davem@davemloft.net \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nico@fluxnic.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.