From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46921)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XtEln-00089u-By
	for qemu-devel@nongnu.org; Tue, 25 Nov 2014 06:59:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XtElh-00028c-7a
	for qemu-devel@nongnu.org; Tue, 25 Nov 2014 06:58:59 -0500
Received: from mx1.redhat.com ([209.132.183.28]:51310)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XtElh-00028W-0G
	for qemu-devel@nongnu.org; Tue, 25 Nov 2014 06:58:53 -0500
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAPBwqeK001984
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Tue, 25 Nov 2014 06:58:52 -0500
From: Markus Armbruster <armbru@redhat.com>
References: <1416899934-13952-1-git-send-email-kraxel@redhat.com>
	<87ioi3puut.fsf@blackfin.pond.sub.org>
	<20141125083700.GA26731@air.redhat.com>
Date: Tue, 25 Nov 2014 12:58:49 +0100
In-Reply-To: <20141125083700.GA26731@air.redhat.com> (Amos Kong's message of
	"Tue, 25 Nov 2014 16:37:00 +0800")
Message-ID: <87fvd7lcee.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH] input: move input-send-event into
	experimental namespace
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amos Kong <akong@redhat.com>
Cc: qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>

Amos Kong <akong@redhat.com> writes:

> On Tue, Nov 25, 2014 at 09:06:34AM +0100, Markus Armbruster wrote:
>> Gerd Hoffmann <kraxel@redhat.com> writes:
>> 
>> > Ongoing discussions on how we are going to specify the console,
>> > so tag the command as experiemntal so we can refine things in
>> > the 2.3 development cycle.
>> >
>> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>> > ---
>> >  qmp-commands.hx | 12 ++++++------
>> 
>> Don't you need to patch qapi-schema.json, too?
>
> Not necessary in function level.

s/need to/want to/?

For consistency, especially because the QAPI schema also serves as QMP
command documentation.

>> Do we actually explain "x- means experimental" anywhere?
>
> What's the official way to make command experimental?

I think we have an understanding / convention that an "x-" prefix marks
names as unstable API.  But I can't find it spelled out anywhere.
Anyway, separate issue.

> Quote from qapi-schema.json:
> | # Notes: This command is experimental and may change
> | syntax in future releases.

Next to the return type ObjectTypeInfo rathe than the command
qom-list-types, blech.