From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754660AbaJNGyB (ORCPT ); Tue, 14 Oct 2014 02:54:01 -0400 Received: from ozlabs.org ([103.22.144.67]:44502 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754161AbaJNGxy (ORCPT ); Tue, 14 Oct 2014 02:53:54 -0400 From: Rusty Russell To: Andy Lutomirski , Andrew Morton , linux-kernel@vger.kernel.org Cc: Chuck Ebbert , Rob Landley , Randy Dunlap , Shuah Khan , Andy Lutomirski Subject: Re: [PATCH v5] init: Disable defaults if init= fails In-Reply-To: <5c6381879bea68aebb13530442f1cf8a052be97f.1411958379.git.luto@amacapital.net> References: <5c6381879bea68aebb13530442f1cf8a052be97f.1411958379.git.luto@amacapital.net> User-Agent: Notmuch/0.17 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Tue, 14 Oct 2014 11:17:09 +1030 Message-ID: <87fvercwaa.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andy Lutomirski writes: > If a user puts init=/whatever on the command line and /whatever > can't be run, then the kernel will try a few default options before > giving up. If init=/whatever came from a bootloader prompt, then > this is unexpected but probably harmless. On the other hand, if it > comes from a script (e.g. a tool like virtme or perhaps a future > kselftest script), then the fallbacks are likely to exist, but > they'll do the wrong thing. For example, they might unexpectedly > invoke systemd. > > This makes a failure to run the specified init= process be fatal. > > As a temporary measure, users can set CONFIG_INIT_FALLBACK=y to > preserve the old behavior. If no one speaks up, we can remove that > option entirely after a release or two. > > Signed-off-by: Andy Lutomirski Acked-by: Rusty Russell Andrew, please apply. Thanks, Rusty.