From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42325) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYX6W-0005Ir-KU for qemu-devel@nongnu.org; Mon, 29 Sep 2014 05:18:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XYX6R-0003YT-Tx for qemu-devel@nongnu.org; Mon, 29 Sep 2014 05:18:48 -0400 From: Markus Armbruster References: <201409291637594172481@sangfor.com> Date: Mon, 29 Sep 2014 11:18:33 +0200 In-Reply-To: <201409291637594172481@sangfor.com> (Zhang Haoyu's message of "Mon, 29 Sep 2014 16:38:02 +0800") Message-ID: <87fvfapyxi.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH bugfix v2] snapshot: fix referencing wrong variable in while loop in do_delvm List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Zhang Haoyu Cc: Kevin Wolf , qemu-devel , Stefan Hajnoczi , qemu-stable@nongnu.org Dropping cc: xiawenc@linux.ibm.com, because I got a "user unknown" bounce. Copying qemu-stable. "Zhang Haoyu" writes: > The while loop variabal is "bs1", > but "bs" is always passed to bdrv_snapshot_delete_by_id_or_name. > Broken in commit a89d89d, v1.7.0. > > v1 -> v2: > * add broken commit id to commit message Patch version information... > Signed-off-by: Zhang Haoyu > Reviewed-by: Markus Armbruster > --- ... goes here, so it doesn't go into the permanent commit message. Maybe Kevin or Stefan can clean it up on commit. > savevm.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) [...]