From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43155)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XLvKi-0006CU-6t
	for qemu-devel@nongnu.org; Mon, 25 Aug 2014 10:33:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XLvKc-00081S-2p
	for qemu-devel@nongnu.org; Mon, 25 Aug 2014 10:33:20 -0400
Received: from mx1.redhat.com ([209.132.183.28]:33881)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XLvKb-00081H-SV
	for qemu-devel@nongnu.org; Mon, 25 Aug 2014 10:33:14 -0400
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
	(int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7PEXDr9020425
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 25 Aug 2014 10:33:13 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1408102357-914-1-git-send-email-armbru@redhat.com>
	<1408102357-914-2-git-send-email-armbru@redhat.com>
	<1408970936.24970.17.camel@nilsson.home.kraxel.org>
Date: Mon, 25 Aug 2014 16:33:10 +0200
In-Reply-To: <1408970936.24970.17.camel@nilsson.home.kraxel.org> (Gerd
	Hoffmann's message of "Mon, 25 Aug 2014 14:48:56 +0200")
Message-ID: <87fvgkiqqh.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 1/2] usb: Fix bootindex for portnr > 9
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: kwolf@redhat.com, lersek@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com

Gerd Hoffmann <kraxel@redhat.com> writes:

> On Fr, 2014-08-15 at 13:32 +0200, Markus Armbruster wrote:
>> We identify devices by their Open Firmware device paths.  The encoding
>> of the host controller and hub port numbers is incorrect:
>> usb_get_fw_dev_path() formats them in decimal, while SeaBIOS uses
>> hexadecimal.  When some port number > 9, SeaBIOS will miss the
>> bootindex (lucky case), or apply it to another device (unlucky case).
>> 
>> The relevant spec[*] agrees with SeaBIOS (and OVMF, for that matter).
>> Change %d to %x.
>> 
>> Bug can bite only with host controllers or hubs sporting more than ten
>> ports.  I'm not aware of any.
>
> fyi: xhci can be configured with up to 15 ports (default is 4 ports
> though).

Would be nice to put that into the commit message, between my S-o-B and
yours.

> Applied to usb patch queue.

Thanks!