From: Rusty Russell <rusty@rustcorp.com.au>
To: Andi Kleen <andi@firstfloor.org>, linux-kernel@vger.kernel.org
Cc: Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 1/2] params: Add a per cpu module param type
Date: Wed, 20 Aug 2014 03:37:48 +0930 [thread overview]
Message-ID: <87fvgsjqtn.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1408461389-24163-1-git-send-email-andi@firstfloor.org>
Andi Kleen <andi@firstfloor.org> writes:
> From: Andi Kleen <ak@linux.intel.com>
>
> This is mainly useful for simple statistic counters.
> Essentially read-only, writing only clears.
Nice...
> +#define param_check_percpu_uint(name, p) param_check_uint
This is wrong; will it even compile? It should also do the __percpu
annotation so hopefully sparse will catch any misuses, eg:
#define param_check_percpu_uint(name, p) \
__param_check(name, p, __percpu unsigned int)
The rest looks good, but I'll need a user :)
Cheers,
Rusty.
prev parent reply other threads:[~2014-08-19 18:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 15:16 [PATCH 1/2] params: Add a per cpu module param type Andi Kleen
2014-08-19 15:16 ` [PATCH 2/2] params: Add static key module param Andi Kleen
2014-08-19 18:07 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvgsjqtn.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.