From: Markus Armbruster <armbru@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
Michael Tokarev <mjt@tls.msk.ru>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PULL for-2.0 00/11] Trivial patches for 2014-04-08
Date: Tue, 08 Apr 2014 12:57:22 +0200 [thread overview]
Message-ID: <87fvlot7fx.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <CAFEAcA9xr+fyjACcvn7N=dMdMmsm6j++Vosqz1XZmzr125WqoQ@mail.gmail.com> (Peter Maydell's message of "Tue, 8 Apr 2014 10:41:22 +0100")
Peter Maydell <peter.maydell@linaro.org> writes:
> On 8 April 2014 09:52, Michael Tokarev <mjt@tls.msk.ru> wrote:
>> Well. At least one of them is entirely safe (hw/ide/ahci.c).
>> Another - xbzrle.c - looks okay, and even maybe fixing a bug.
>> And this int128 thing is okay too, except that the whole thing
>> is questionable as has been mentioned in that thread.
>>
>> I can prepare another pull request without xbzrle and int128 changes,
>> or even without ahci change too, but I'm not sure it is worth the
>> effort - I think everything is okay to go. I'll take your word for this.
>
> Well, anything that goes in today is going to get at best two
> days of being tested before the release. To me that argues
> fairly strongly for not putting anything in unless it is
> fixing a genuine bug.
Seconded.
WARNING: multiple messages have this Message-ID (diff)
From: Markus Armbruster <armbru@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
Michael Tokarev <mjt@tls.msk.ru>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL for-2.0 00/11] Trivial patches for 2014-04-08
Date: Tue, 08 Apr 2014 12:57:22 +0200 [thread overview]
Message-ID: <87fvlot7fx.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <CAFEAcA9xr+fyjACcvn7N=dMdMmsm6j++Vosqz1XZmzr125WqoQ@mail.gmail.com> (Peter Maydell's message of "Tue, 8 Apr 2014 10:41:22 +0100")
Peter Maydell <peter.maydell@linaro.org> writes:
> On 8 April 2014 09:52, Michael Tokarev <mjt@tls.msk.ru> wrote:
>> Well. At least one of them is entirely safe (hw/ide/ahci.c).
>> Another - xbzrle.c - looks okay, and even maybe fixing a bug.
>> And this int128 thing is okay too, except that the whole thing
>> is questionable as has been mentioned in that thread.
>>
>> I can prepare another pull request without xbzrle and int128 changes,
>> or even without ahci change too, but I'm not sure it is worth the
>> effort - I think everything is okay to go. I'll take your word for this.
>
> Well, anything that goes in today is going to get at best two
> days of being tested before the release. To me that argues
> fairly strongly for not putting anything in unless it is
> fixing a genuine bug.
Seconded.
next prev parent reply other threads:[~2014-04-08 10:57 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-08 7:04 [Qemu-trivial] [PULL for-2.0 00/11] Trivial patches for 2014-04-08 Michael Tokarev
2014-04-08 7:04 ` [Qemu-devel] " Michael Tokarev
2014-04-08 7:04 ` [Qemu-trivial] [PULL 01/11] vl: Report accelerator not supported for target more nicely Michael Tokarev
2014-04-08 7:04 ` [Qemu-devel] " Michael Tokarev
2014-04-08 7:18 ` [Qemu-trivial] " Chen Gang
2014-04-08 7:18 ` [Qemu-devel] " Chen Gang
2014-04-08 7:04 ` [Qemu-trivial] [PULL 02/11] qga: trivial fix for unclear documentation of guest-set-time Michael Tokarev
2014-04-08 7:04 ` [Qemu-devel] " Michael Tokarev
2014-04-08 7:04 ` [Qemu-trivial] [PULL 03/11] configure: Fix indentation of help for --enable/disable-debug-info Michael Tokarev
2014-04-08 7:04 ` [Qemu-devel] " Michael Tokarev
2014-04-08 7:04 ` [Qemu-trivial] [PULL 04/11] net: Report error when device / hub combo is not found Michael Tokarev
2014-04-08 7:04 ` [Qemu-devel] " Michael Tokarev
2014-04-08 7:04 ` [Qemu-trivial] [PULL 05/11] hw/ide/ahci.c: Avoid shift left into sign bit Michael Tokarev
2014-04-08 7:04 ` [Qemu-devel] " Michael Tokarev
2014-04-08 7:04 ` [Qemu-trivial] [PULL 06/11] int128.h: Avoid undefined behaviours involving signed arithmetic Michael Tokarev
2014-04-08 7:04 ` [Qemu-devel] " Michael Tokarev
2014-04-08 7:04 ` [Qemu-trivial] [PULL 07/11] xbzrle.c: Avoid undefined behaviour with " Michael Tokarev
2014-04-08 7:04 ` [Qemu-devel] " Michael Tokarev
2014-04-08 7:04 ` [Qemu-trivial] [PULL 08/11] scripts: add sample model file for Coverity Scan Michael Tokarev
2014-04-08 7:04 ` [Qemu-devel] " Michael Tokarev
2014-04-08 7:04 ` [Qemu-trivial] [PULL 09/11] configure: Remove redundant message for -Werror Michael Tokarev
2014-04-08 7:04 ` [Qemu-devel] " Michael Tokarev
2014-04-08 7:04 ` [Qemu-trivial] [PULL 10/11] doc: grammify "allows to" Michael Tokarev
2014-04-08 7:04 ` [Qemu-devel] " Michael Tokarev
2014-04-08 7:04 ` [Qemu-trivial] [PULL 11/11] Fix grammar in comment Michael Tokarev
2014-04-08 7:04 ` [Qemu-devel] " Michael Tokarev
2014-04-08 8:10 ` [Qemu-trivial] [Qemu-devel] [PULL for-2.0 00/11] Trivial patches for 2014-04-08 Peter Maydell
2014-04-08 8:10 ` Peter Maydell
2014-04-08 8:52 ` [Qemu-trivial] " Michael Tokarev
2014-04-08 8:52 ` Michael Tokarev
2014-04-08 9:41 ` [Qemu-trivial] " Peter Maydell
2014-04-08 9:41 ` Peter Maydell
2014-04-08 10:57 ` Markus Armbruster [this message]
2014-04-08 10:57 ` Markus Armbruster
2014-04-08 11:58 ` [Qemu-trivial] " Michael Tokarev
2014-04-08 11:58 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvlot7fx.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.