From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35777) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPqGS-0006UP-5L for qemu-devel@nongnu.org; Tue, 18 Mar 2014 05:24:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WPqGM-0002w7-Ka for qemu-devel@nongnu.org; Tue, 18 Mar 2014 05:24:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14533) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPqGM-0002vz-Bs for qemu-devel@nongnu.org; Tue, 18 Mar 2014 05:24:46 -0400 From: Markus Armbruster References: <1395093205-46337-1-git-send-email-borntraeger@de.ibm.com> <1395093590.13766.2.camel@localhost.localdomain> Date: Tue, 18 Mar 2014 10:24:24 +0100 In-Reply-To: <1395093590.13766.2.camel@localhost.localdomain> (Marcel Apfelbaum's message of "Mon, 17 Mar 2014 23:59:50 +0200") Message-ID: <87fvmfvozb.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] vl.c: Fix memory leak in qemu_register_machine List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum Cc: Christian Borntraeger , "Michael S. Tsirkin" , "qemu-devel@nongnu.org" , Andreas =?utf-8?Q?F?= =?utf-8?Q?=C3=A4rber?= , Peter Maydell Marcel Apfelbaum writes: > On Mon, 2014-03-17 at 22:53 +0100, Christian Borntraeger wrote: >> since commit 261747f176f6 (vl: Use MachineClass instead of global >> QEMUMachine list) valgrind complains about the following: >> >> ==54082== 57 bytes in 3 blocks are definitely lost in loss record 365 of 729 >> ==54082== at 0x4031AFE: malloc (vg_replace_malloc.c:292) >> ==54082== by 0x4145569: g_malloc (in /usr/lib64/libglib-2.0.so.0.3400.2) >> ==54082== by 0x415F9E9: g_strconcat (in /usr/lib64/libglib-2.0.so.0.3400.2) >> ==54082== by 0x80157FE7: qemu_register_machine (vl.c:1597) >> ==54082== by 0x80208E6B: module_call_init (module.c:105) >> ==54082== by 0x80013B91: main (vl.c:3000) >> >> Turns out that valgrind is right. We simply forget the memory that >> g_strconcat has allocated. Lets free it after the type_register. >> >> Signed-off-by: Christian Borntraeger >> --- >> vl.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/vl.c b/vl.c >> index b363a21..97290c9 100644 >> --- a/vl.c >> +++ b/vl.c >> @@ -1592,6 +1592,7 @@ int qemu_register_machine(QEMUMachine *m) >> }; >> >> type_register(&ti); >> + g_free((void *) ti.name); > I would remove the ^ space here, but maybe Andreas can remove it when > he applies it. To be precise: no space between cast and its operand: (void *)ti.name [...]