From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51016) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNkMX-0003sS-IS for qemu-devel@nongnu.org; Wed, 12 Mar 2014 10:42:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNkMR-0006sY-BE for qemu-devel@nongnu.org; Wed, 12 Mar 2014 10:42:29 -0400 Received: from roura.ac.upc.edu ([147.83.33.10]:49433 helo=roura.ac.upc.es) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNkMQ-0006sQ-Vh for qemu-devel@nongnu.org; Wed, 12 Mar 2014 10:42:23 -0400 From: =?utf-8?Q?Llu=C3=ADs_Vilanova?= References: <20140223193656.28465.12158.stgit@fimbulvetr.bsc.es> <20140223193735.28465.61469.stgit@fimbulvetr.bsc.es> <20140312141737.GB903@stefanha-thinkpad.muc.redhat.com> Date: Wed, 12 Mar 2014 15:42:19 +0100 In-Reply-To: <20140312141737.GB903@stefanha-thinkpad.muc.redhat.com> (Stefan Hajnoczi's message of "Wed, 12 Mar 2014 15:17:37 +0100") Message-ID: <87fvmneawk.fsf@fimbulvetr.bsc.es> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 7/8] trace: [simple] Bump up log version number List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org Stefan Hajnoczi writes: > On Sun, Feb 23, 2014 at 08:37:35PM +0100, Llu=C3=ADs Vilanova wrote: >> The following tracetool cleanup changes the event numbering policy. >>=20 >> Signed-off-by: Llu=C3=ADs Vilanova >> --- >> scripts/simpletrace.py | 10 +++++----- >> trace/simple.c | 2 +- >> 2 files changed, 6 insertions(+), 6 deletions(-) > I would also like to add a change to the simpletrace binary format. The > 32-bit reserved field will take the pid of QEMU. I will also submit a > SystemTap script that produces simpletrace binary format output - this > allows us to produce simpletrace-compatible data with a QEMU binary that > only has SystemTap support. Since SystemTap is global it sees all QEMU > processes and we need to distinguish between them using the pid. > Your series will be merged into qemu.git at the start of the QEMU 2.1 > release cycle. My patch can follow during the release cycle. End-users > will not see the changes until QEMU 2.1 is released. Sounds excellent, but note that I also wrote a patch for multi-backend trac= ing based on Kazuya's idea (must be applied on top of this series). Not sure if= that would influence your decision about SystemTap's format (since you could then have both compiled into QEMU). I will later send the latest version (rebased on this series). Thanks, Lluis --=20 "And it's much the same thing with knowledge, for whenever you learn something new, the whole world becomes that much richer." -- The Princess of Pure Reason, as told by Norton Juster in The Phantom Tollbooth