From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51003) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W98kE-000716-8G for qemu-devel@nongnu.org; Fri, 31 Jan 2014 02:42:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W98k8-0006Gh-3v for qemu-devel@nongnu.org; Fri, 31 Jan 2014 02:42:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:18585) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W98k7-0006GH-SW for qemu-devel@nongnu.org; Fri, 31 Jan 2014 02:42:28 -0500 From: Markus Armbruster References: <1391090848-2115-1-git-send-email-armbru@redhat.com> <52EA8866.6050302@suse.de> Date: Fri, 31 Jan 2014 08:42:22 +0100 In-Reply-To: <52EA8866.6050302@suse.de> ("Andreas =?utf-8?Q?F=C3=A4rber=22?= =?utf-8?Q?'s?= message of "Thu, 30 Jan 2014 18:14:14 +0100") Message-ID: <87fvo4y4v5.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] Use error_is_set() only when necessary List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?utf-8?Q?F=C3=A4rber?= Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com Andreas F=C3=A4rber writes: > Am 30.01.2014 15:07, schrieb Markus Armbruster: >> error_is_set(&var) is the same as var !=3D NULL, but it takes >> whole-program analysis to figure that out. Unnecessarily hard for >> optimizers, static checkers, and human readers. Dumb it down to >> obvious. >>=20 >> Gets rid of several dozen Coverity false positives. >>=20 >> Note that the obvious form is already used in many places. >>=20 >> Signed-off-by: Markus Armbruster > > Reviewed-by: Andreas F=C3=A4rber Thanks! > I don't suppose you used a Coccinelle script that we could re-run in the > future? ;) Perhaps I should've, but since the job was simple enough for M-x tags-query-replace... > Via QMP queue? Yes, please.