From: Werner Koch <wk@gnupg.org>
To: Milan Broz <gmazyland@gmail.com>
Cc: dm-crypt <dm-crypt@saout.de>, gcrypt-devel@gnupg.org
Subject: Re: [dm-crypt] Whirlpool in gcrypt <= 1.5.3 broken (if writes in chunks)?
Date: Sun, 19 Jan 2014 15:13:43 +0100 [thread overview]
Message-ID: <87fvokys88.fsf@vigenere.g10code.de> (raw)
In-Reply-To: <52D9995F.1070808@gmail.com> (Milan Broz's message of "Fri, 17 Jan 2014 21:58:07 +0100")
On Fri, 17 Jan 2014 21:58, gmazyland@gmail.com said:
> So if there is a "bug emulation flag" it could help to implement it.
Done in master. The code is not very sophisticated: I added the flag and
then re-added most of the old code. If this works out for you I
will backport it to 1.6 and release a 1.6.1 soon.
The suggested way of using the flag is:
if (whirlpool_bug_assumed)
{
#if GCRYPT_VERSION_NUMBER >= 0x010601
err = gcry_md_open (&hd, GCRY_MD_WHIRLPOOL, GCRY_MD_FLAG_BUGEMU1)
if (gpg_err_code (err) == GPG_ERR_INV_ARG)
error ("Need at least Libggcrypt 1.6.1 for the fix");
else
{
do_hash (hd);
gcry_md_close (hd);
}
#endif
}
Salam-Shalom,
Werner
--
Die Gedanken sind frei. Ausnahmen regelt ein Bundesgesetz.
next prev parent reply other threads:[~2014-01-19 14:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-17 18:25 [dm-crypt] Whirlpool in gcrypt <= 1.5.3 broken (if writes in chunks)? Milan Broz
2014-01-17 20:26 ` Werner Koch
2014-01-17 20:58 ` Milan Broz
2014-01-19 14:13 ` Werner Koch [this message]
2014-01-19 19:49 ` Milan Broz
2014-01-20 7:56 ` Werner Koch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvokys88.fsf@vigenere.g10code.de \
--to=wk@gnupg.org \
--cc=dm-crypt@saout.de \
--cc=gcrypt-devel@gnupg.org \
--cc=gmazyland@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.