From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55862)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1W0Tef-0008Gs-V4
	for qemu-devel@nongnu.org; Tue, 07 Jan 2014 05:13:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1W0Tea-00030H-QL
	for qemu-devel@nongnu.org; Tue, 07 Jan 2014 05:13:01 -0500
Received: from mx1.redhat.com ([209.132.183.28]:38097)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1W0Tea-0002zH-JM
	for qemu-devel@nongnu.org; Tue, 07 Jan 2014 05:12:56 -0500
From: Markus Armbruster <armbru@redhat.com>
References: <1385726178-10201-1-git-send-email-kirill.shutemov@linux.intel.com>
	<20131209102517.33F4EE0090@blue.fi.intel.com>
	<87ppp6b6yo.fsf@linux.vnet.ibm.com>
	<20131223122138.931E2E0090@blue.fi.intel.com>
Date: Tue, 07 Jan 2014 11:12:50 +0100
In-Reply-To: <20131223122138.931E2E0090@blue.fi.intel.com> (Kirill
	A. Shutemov's message of "Mon, 23 Dec 2013 14:21:38 +0200 (EET)")
Message-ID: <87fvp02j8d.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [RESEND-try-2][PATCH] hw/9pfs: fix P9_STATS_GEN
	handling
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>, aliguori@amazon.com, qemu-devel@nongnu.org

"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> writes:

> Aneesh Kumar K.V wrote:
>> "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> writes:
>> 
>> > Kirill A. Shutemov wrote:
>> >> Currently we have few issues with P9_STATS_GEN:
>> >> 
>> >>  - We don't try to read st_gen anything except files or directories, but
>> >>    still set P9_STATS_GEN bit in st_result_mask. It may mislead client:
>> >>    we present garbage as valid st_gen.
>> >> 
>> >>  - If we failed to get valid st_gen with ENOTTY, we ignore error, but
>> >>    still set P9_STATS_GEN bit in st_result_mask.
>> >> 
>> >>  - If we failed to get valid st_gen with any other errno, we fail
>> >>    getattr altogether. It's excessive: we block valid client use-cases,
>> >>    like chdir(2) to non-readable directory with execution bit set.
>> >> 
>> >> The patch fixes these issues and cleanup code a bit.
>> >> 
>> >> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
>> >> Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
>> >> Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
>> >
>> > Ping?
>> >
>> 
>> I am hoping that this will go to upstream directly without me doing a
>> pull request ? Anthony, let me know if this need anything to be done
>> from my side
>
> So? Nobody cares?

Unlikely.  Your problem is that the "Anthony" route for patches has been
dug up, and approximately 95% of the traffic still trying to navigate it
fall into its holes and vanish without trace.  Recommend to try another
route.