From: Markus Armbruster <armbru@redhat.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH 2/5] machine: introduce get_fw_dev_path() callback
Date: Tue, 03 Dec 2013 10:11:21 +0100 [thread overview]
Message-ID: <87fvqaqoxy.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <529D5570.8060205@ozlabs.ru> (Alexey Kardashevskiy's message of "Tue, 03 Dec 2013 14:52:16 +1100")
Alexey Kardashevskiy <aik@ozlabs.ru> writes:
> On 11/26/2013 03:55 PM, Alexey Kardashevskiy wrote:
>> Hi!
>>
>> btw there is a problem with this patch - it does not compile for
>> "linux-user" as there is no current-machine global variable defined in vl.c
>> which is not compiled for linux-user.
>>
>> How to solve this problem correctly?
[...]
> Anyone, please?
>
> The only easy fix for this I can think of would be this:
>
> extern QEMUMachine *current_machine __attribute__((weak));
>
>
> But I suspect this is disgusting? :)
Absolutely not. It's merely not portable to machines with object file
formats and linkers stuck in the 80s. However, we routinely twist
ourselves into knots for portability (observation, not endorsement), and
at least one previous attempt[*] to introduce weak symbols got nowhere.
[*] https://lists.nongnu.org/archive/html/qemu-devel/2012-07/msg03853.html
next prev parent reply other threads:[~2013-12-03 9:11 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 7:27 [Qemu-devel] [RFC PATCH 0/5] spapr: support bootindex Alexey Kardashevskiy
2013-11-25 7:27 ` [Qemu-devel] [PATCH 1/5] boot: extend get_boot_devices_list() to ignore suffixes Alexey Kardashevskiy
2013-11-25 7:27 ` [Qemu-devel] [PATCH 2/5] machine: introduce get_fw_dev_path() callback Alexey Kardashevskiy
2013-11-26 4:55 ` Alexey Kardashevskiy
2013-12-03 3:52 ` Alexey Kardashevskiy
2013-12-03 9:11 ` Markus Armbruster [this message]
2013-12-03 9:32 ` Alexey Kardashevskiy
2013-12-03 9:41 ` Paolo Bonzini
2013-12-03 13:41 ` Andreas Färber
2013-12-03 9:37 ` Paolo Bonzini
2013-12-03 13:44 ` Andreas Färber
2013-12-03 14:00 ` Paolo Bonzini
2013-12-03 14:35 ` Andreas Färber
2013-12-03 14:58 ` Paolo Bonzini
2013-12-11 5:20 ` Alexey Kardashevskiy
2013-12-11 7:47 ` Paolo Bonzini
2013-12-11 7:59 ` Alexey Kardashevskiy
2013-12-11 8:38 ` Alexey Kardashevskiy
2013-12-10 7:34 ` Alexey Kardashevskiy
2013-11-25 7:27 ` [Qemu-devel] [PATCH 3/5] spapr-llan: add to boot device list Alexey Kardashevskiy
2013-11-25 7:27 ` [Qemu-devel] [PATCH 4/5] spapr-vio: fix firmware names Alexey Kardashevskiy
2013-11-25 7:27 ` [Qemu-devel] [PATCH 5/5] spapr: define get_fw_dev_path() callback Alexey Kardashevskiy
2013-11-26 4:05 ` [Qemu-devel] [PATCH v2] " Alexey Kardashevskiy
2013-11-26 4:07 ` [PATCH] boot: enable support for bootindex Alexey Kardashevskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvqaqoxy.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=afaerber@suse.de \
--cc=aik@ozlabs.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.