From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VVkLr-00035C-M4 for ath10k@lists.infradead.org; Mon, 14 Oct 2013 15:46:36 +0000 From: Kalle Valo Subject: Re: [PATCH] ath10k: do not warn about unsupported vdev param References: <1381749381-15459-1-git-send-email-bartosz.markowski@tieto.com> Date: Mon, 14 Oct 2013 18:46:05 +0300 In-Reply-To: <1381749381-15459-1-git-send-email-bartosz.markowski@tieto.com> (Bartosz Markowski's message of "Mon, 14 Oct 2013 13:16:21 +0200") Message-ID: <87fvs3etz6.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Bartosz Markowski Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Bartosz Markowski writes: > 10.X firmware does not support WMI_VDEV_PARAM_TX_ENCAP_TYPE. > It's a known limitation and we should not warn about this. > > Signed-off-by: Bartosz Markowski > --- > drivers/net/wireless/ath/ath10k/mac.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c > index 049eca2..9c800f8 100644 > --- a/drivers/net/wireless/ath/ath10k/mac.c > +++ b/drivers/net/wireless/ath/ath10k/mac.c > @@ -2085,7 +2085,9 @@ static int ath10k_add_interface(struct ieee80211_hw *hw, > vdev_param = ar->wmi.vdev_param->tx_encap_type; > ret = ath10k_wmi_vdev_set_param(ar, arvif->vdev_id, vdev_param, > ATH10K_HW_TXRX_NATIVE_WIFI); > - if (ret) > + > + /* 10.X firmware does not support this VDEV parameter. Do not warn */ > + if (ret && !test_bit(ATH10K_FW_FEATURE_WMI_10X, ar->fw_features)) > ath10k_warn("Failed to set TX encap: %d\n", ret); But why call ath10k_wmi_vdev_set_param() even if we know it won't work? IMHO it's cleaner not to call it at all when ATH10K_FW_FEATURE_WMI_10X is set. Or if we want to avoid using ATH10K_FW_FEATURE_WMI_10X we could also change ath10k_wmi_pdev_set_param() to return -EOPNOTSUPP and check for that. -- Kalle Valo _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from sabertooth02.qualcomm.com ([65.197.215.38]:21970 "EHLO sabertooth02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754487Ab3JNPqW (ORCPT ); Mon, 14 Oct 2013 11:46:22 -0400 From: Kalle Valo To: Bartosz Markowski CC: , Subject: Re: [PATCH] ath10k: do not warn about unsupported vdev param References: <1381749381-15459-1-git-send-email-bartosz.markowski@tieto.com> Date: Mon, 14 Oct 2013 18:46:05 +0300 In-Reply-To: <1381749381-15459-1-git-send-email-bartosz.markowski@tieto.com> (Bartosz Markowski's message of "Mon, 14 Oct 2013 13:16:21 +0200") Message-ID: <87fvs3etz6.fsf@kamboji.qca.qualcomm.com> (sfid-20131014_174634_576500_49438318) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-wireless-owner@vger.kernel.org List-ID: Bartosz Markowski writes: > 10.X firmware does not support WMI_VDEV_PARAM_TX_ENCAP_TYPE. > It's a known limitation and we should not warn about this. > > Signed-off-by: Bartosz Markowski > --- > drivers/net/wireless/ath/ath10k/mac.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c > index 049eca2..9c800f8 100644 > --- a/drivers/net/wireless/ath/ath10k/mac.c > +++ b/drivers/net/wireless/ath/ath10k/mac.c > @@ -2085,7 +2085,9 @@ static int ath10k_add_interface(struct ieee80211_hw *hw, > vdev_param = ar->wmi.vdev_param->tx_encap_type; > ret = ath10k_wmi_vdev_set_param(ar, arvif->vdev_id, vdev_param, > ATH10K_HW_TXRX_NATIVE_WIFI); > - if (ret) > + > + /* 10.X firmware does not support this VDEV parameter. Do not warn */ > + if (ret && !test_bit(ATH10K_FW_FEATURE_WMI_10X, ar->fw_features)) > ath10k_warn("Failed to set TX encap: %d\n", ret); But why call ath10k_wmi_vdev_set_param() even if we know it won't work? IMHO it's cleaner not to call it at all when ATH10K_FW_FEATURE_WMI_10X is set. Or if we want to avoid using ATH10K_FW_FEATURE_WMI_10X we could also change ath10k_wmi_pdev_set_param() to return -EOPNOTSUPP and check for that. -- Kalle Valo