From: Yoshinori Sato <ysato@users.sourceforge.jp>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] h8300: Fix <asm/tlb.h>
Date: Sun, 12 May 2013 20:50:51 +0900 [thread overview]
Message-ID: <87fvxsh0x0.wl%ysato@users.sourceforge.jp> (raw)
In-Reply-To: <1367920372-18429-1-git-send-email-geert@linux-m68k.org>
At Tue, 7 May 2013 11:52:52 +0200,
Geert Uytterhoeven wrote:
>
> Ten years ago, a mismerge happened, concatenating two slightly different
> versions of the same file. As a consequence, <asm-generic/tlb.h> was never
> included, leading to a build failure only now:
>
> kernel/cpu/idle.c: In function 'cpu_idle_loop':
> kernel/cpu/idle.c:70:4: error: implicit declaration of function 'check_pgt_cache' [-Werror=implicit-function-declaration]
>
> Remove the duplicates, and the header comment with the no longer correct
> file name.
Sorry. too late reply.
OK. I will fix my tree.
Thanks.
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Yoshinori Sato <ysato@users.sourceforge.jp>
> ---
> arch/h8300/include/asm/tlb.h | 15 ---------------
> 1 files changed, 0 insertions(+), 15 deletions(-)
>
> diff --git a/arch/h8300/include/asm/tlb.h b/arch/h8300/include/asm/tlb.h
> index 3dea80a..7f07430 100644
> --- a/arch/h8300/include/asm/tlb.h
> +++ b/arch/h8300/include/asm/tlb.h
> @@ -1,16 +1,3 @@
> -/*
> - include/asm-h8300/tlb.h
> -*/
> -
> -#ifndef __H8300_TLB_H__
> -#define __H8300_TLB_H__
> -
> -#define tlb_flush(tlb) do { } while(0)
> -
> -/*
> - include/asm-h8300/tlb.h
> -*/
> -
> #ifndef __H8300_TLB_H__
> #define __H8300_TLB_H__
>
> @@ -19,5 +6,3 @@
> #include <asm-generic/tlb.h>
>
> #endif
> -
> -#endif
> --
> 1.7.0.4
>
--
Yoshinori Sato
<ysato@users.sourceforge.jp>
prev parent reply other threads:[~2013-05-12 12:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-07 9:52 [PATCH] h8300: Fix <asm/tlb.h> Geert Uytterhoeven
2013-05-12 11:50 ` Yoshinori Sato [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvxsh0x0.wl%ysato@users.sourceforge.jp \
--to=ysato@users.sourceforge.jp \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.