From mboxrd@z Thu Jan 1 00:00:00 1970 From: OGAWA Hirofumi Subject: Re: [PATCH RESEND v5] fat: editions to support fat_fallocate Date: Thu, 02 May 2013 18:34:08 +0900 Message-ID: <87fvy53eun.fsf@devron.myhome.or.jp> References: <1367107703-2665-1-git-send-email-linkinjeon@gmail.com> <87ppxd4ddm.fsf@devron.myhome.or.jp> <87bo8v42wx.fsf@devron.myhome.or.jp> <87vc722cdu.fsf@devron.myhome.or.jp> <87r4hp3kax.fsf@devron.myhome.or.jp> <87k3nh3jzi.fsf@devron.myhome.or.jp> Mime-Version: 1.0 Content-Type: text/plain Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Namjae Jeon , Amit Sahrawat To: Namjae Jeon Return-path: In-Reply-To: (Namjae Jeon's message of "Thu, 2 May 2013 18:15:21 +0900") Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Namjae Jeon writes: >>> AFAIK, preallocation != fallocate. ext*'s preallocation was there at >>> before fallocation to optimize block allocation for user data blocks. > yes, this is correct , preallocation!= fallocate, we just adopted only > the "release part" from that approach > Sorry, Would you mind to adopt this approach :) ? I'm ok as start if it works. But from this discussion, discard at last close(2) doesn't look like working for your requirement. Since you want to discard at last close of inode, so, rather, I guess you actually want to discard at last dereference of inode. Thanks. -- OGAWA Hirofumi