From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48880) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVS2v-0004VC-KU for qemu-devel@nongnu.org; Thu, 25 Apr 2013 15:41:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UVS2u-0004Ti-0J for qemu-devel@nongnu.org; Thu, 25 Apr 2013 15:41:33 -0400 Received: from e23smtp07.au.ibm.com ([202.81.31.140]:41886) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVS2t-0004KR-E7 for qemu-devel@nongnu.org; Thu, 25 Apr 2013 15:41:31 -0400 Received: from /spool/local by e23smtp07.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 26 Apr 2013 05:31:28 +1000 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [9.190.235.21]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id A5B9E2CE804C for ; Fri, 26 Apr 2013 05:40:56 +1000 (EST) Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r3PJeniI19464206 for ; Fri, 26 Apr 2013 05:40:50 +1000 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r3PJetqu026777 for ; Fri, 26 Apr 2013 05:40:55 +1000 From: Anthony Liguori In-Reply-To: <1366867752-11578-1-git-send-email-lilei@linux.vnet.ibm.com> References: <1366867752-11578-1-git-send-email-lilei@linux.vnet.ibm.com> Date: Thu, 25 Apr 2013 14:40:49 -0500 Message-ID: <87fvyeo0u6.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 0/4 v4] Support for LED state extension to Qemu VNC server List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lei Li , qemu-devel@nongnu.org Cc: lagarcia@br.ibm.com, kraxel@redhat.com Lei Li writes: > Hi guys, > > This patch series tries to add support for LED state > extension to Qemu VNC server. The proposal has been sent > few days ago as link below: > > http://lists.gnu.org/archive/html/qemu-devel/2013-04/msg01421.html > > The previous version as link: > > http://lists.nongnu.org/archive/html/qemu-devel/2013-04/msg04773.html > > Pleae let me know if there is anything else need be improved. > > Thanks! Reviewed-by: Anthony Liguori I'll give people some time to take a look before applying but it looks good to me. Regards, Anthony Liguori > > > Changes since v3: > - Add adjustment of turning off lock state sync logic in do_key_event() > when VNC_FEATURE_LED_STATE supported suggested by Gerd. > - Document improvement suggested by Eric. > > Changes since v2: > - Address the comments from Anthony includes: > - Just send 1 instead of the actual width and height. > - Improve the document by adding the Pseudo-encoding number > and simplify the description of the LED state encoding. > > Changes since v1: > - Address the comments from Anthony includes: > - Use Pseudo-encoding for led state; > - Get rid of send_ext_leds_state_ack; > - Add document for the led state Pseudo-encoding. > > Lei Li (4): > vnc: Add SCROLL lock key to kbd_leds > vnc: Support for LED state extension > vnc: Adjust lock state sync logic with VNC_FEATURE_LED_STATE > doc: document the Pseudo-encoding of LED state > > docs/vnc-ledstate-Pseudo-encoding.txt | 50 +++++++++++++++++++++++++++++ > ui/vnc.c | 56 ++++++++++++++++++++++++++++++++- > ui/vnc.h | 3 ++ > 3 files changed, 108 insertions(+), 1 deletions(-) > create mode 100644 docs/vnc-ledstate-Pseudo-encoding.txt