From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47728) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUiN6-0007uZ-GY for qemu-devel@nongnu.org; Tue, 23 Apr 2013 14:55:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UUiN2-0006dG-Vn for qemu-devel@nongnu.org; Tue, 23 Apr 2013 14:55:20 -0400 Received: from e23smtp09.au.ibm.com ([202.81.31.142]:43722) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUiN2-0006d5-EE for qemu-devel@nongnu.org; Tue, 23 Apr 2013 14:55:16 -0400 Received: from /spool/local by e23smtp09.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 24 Apr 2013 04:45:58 +1000 Received: from d23relay04.au.ibm.com (d23relay04.au.ibm.com [9.190.234.120]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 8E6392CE804A for ; Wed, 24 Apr 2013 04:55:09 +1000 (EST) Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r3NIfWKM10289480 for ; Wed, 24 Apr 2013 04:41:35 +1000 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r3NIt5Vv014058 for ; Wed, 24 Apr 2013 04:55:06 +1000 From: Anthony Liguori In-Reply-To: <5176D716.7070007@linux.vnet.ibm.com> References: <1366682139-22122-1-git-send-email-mrhines@linux.vnet.ibm.com> <87li89dtmc.fsf@codemonkey.ws> <5176CADB.4000304@linux.vnet.ibm.com> <87k3ntm7co.fsf@codemonkey.ws> <5176D716.7070007@linux.vnet.ibm.com> Date: Tue, 23 Apr 2013 13:55:00 -0500 Message-ID: <87fvyhxekb.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH v5 00/12] rdma: migration support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael R. Hines" Cc: quintela@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com, Bulent Abali , Michael R Hines , Gokul B Kandiraju , pbonzini@redhat.com "Michael R. Hines" writes: > On 04/23/2013 02:26 PM, Anthony Liguori wrote: >> "Michael R. Hines" writes: >> >>> On 04/23/2013 01:50 PM, Anthony Liguori wrote: >>>> mrhines@linux.vnet.ibm.com writes: >>>> >>>>> From: "Michael R. Hines" >>>>> >>>>> Juan, Please pull. >>>> I assume this is actually v6, not v5? >>>> >>>> I don't see collected Reviewed-bys... >>>> >>>> That said, we're pretty close to hard freeze. I think this should wait >>>> until 1.6 opens up although I'm open to suggestion if people think this >>>> is low risk. I don't like the idea of adding a new protocol this close >>>> to the end of a cycle. >>>> >>>> Regards, >>>> >>>> Anthony Liguori >>> There are no instructions/procedures documented on the qemu.org >>> website on how to automatically generate "Reviewed-by" signatures. >> I suspect there's some confusion here. Addressed review comments != >> Reviewed-by. There can always be additional comments. Someone has to >> explicitly offer a Reviewed-by indicating that they are happy with the >> patches overall. I've gone through the history on these patches and I >> don't see any explicit Reviewed-by's other than Eric's most recent one. >> >> Give the series a little more time for people to look over it, it'll get >> Reviewed-bys when people are ready to offer them. > > Ah, OK, so then when I receive the signatures by email, do > I just literally "paste" the Reviewed-By directly into the patch series > by hand? Usually you don't get Reviewed-bys until the final submission. For the final submission, you don't have to worry about it as the submaintainer is responsible for adding the Reviewed-bys. > Is this not handled by git? No, I have automated scripts that does this but they are probably too complicated for just submitting patches. Most people just copy/paste for the rare cases where a Reviewed-by carries over from the previous submission. Regards, Anthony Liguori > > - Michael