From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: Re: [RFC PATCH 0/2] make mac programming for virtio net more robust Date: Fri, 11 Jan 2013 12:53:07 +1030 Message-ID: <87fw281mr8.fsf@rustcorp.com.au> References: <1357829141-25455-1-git-send-email-akong@redhat.com> <20130110152829.GG30731@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, qemu-devel@nongnu.org To: "Michael S. Tsirkin" , akong@redhat.com Return-path: Received: from ozlabs.org ([203.10.76.45]:52439 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753387Ab3AKDzp (ORCPT ); Thu, 10 Jan 2013 22:55:45 -0500 In-Reply-To: <20130110152829.GG30731@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: "Michael S. Tsirkin" writes: > On Thu, Jan 10, 2013 at 10:45:39PM +0800, akong@redhat.com wrote: >> From: Amos Kong >> >> Currenly mac is programmed byte by byte. This means that we >> have an intermediate step where mac is wrong. >> >> Second patch introduced a new vq control command to set mac >> address in one time. > > As you mention we could alternatively do it without > new commands, simply add a feature bit that says that MACs are > in the mac table. > This would be a much bigger patch, and I'm fine with either way. > Rusty what do you think? Hmm, mac filtering and "my mac address" are not quite the same thing. I don't know if it matters for anyone: does it? The mac address is abused for things like identifying machines, etc. If we keep it as a separate concept, Amos' patch seems to make sense. Cheers, Rusty. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43678) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtVj5-0001Ke-5Y for qemu-devel@nongnu.org; Thu, 10 Jan 2013 22:56:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TtVij-0007ih-Cc for qemu-devel@nongnu.org; Thu, 10 Jan 2013 22:56:15 -0500 Received: from ozlabs.org ([203.10.76.45]:41232) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtVii-0007gC-VS for qemu-devel@nongnu.org; Thu, 10 Jan 2013 22:55:53 -0500 From: Rusty Russell In-Reply-To: <20130110152829.GG30731@redhat.com> References: <1357829141-25455-1-git-send-email-akong@redhat.com> <20130110152829.GG30731@redhat.com> Date: Fri, 11 Jan 2013 12:53:07 +1030 Message-ID: <87fw281mr8.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [RFC PATCH 0/2] make mac programming for virtio net more robust List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , akong@redhat.com Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org "Michael S. Tsirkin" writes: > On Thu, Jan 10, 2013 at 10:45:39PM +0800, akong@redhat.com wrote: >> From: Amos Kong >> >> Currenly mac is programmed byte by byte. This means that we >> have an intermediate step where mac is wrong. >> >> Second patch introduced a new vq control command to set mac >> address in one time. > > As you mention we could alternatively do it without > new commands, simply add a feature bit that says that MACs are > in the mac table. > This would be a much bigger patch, and I'm fine with either way. > Rusty what do you think? Hmm, mac filtering and "my mac address" are not quite the same thing. I don't know if it matters for anyone: does it? The mac address is abused for things like identifying machines, etc. If we keep it as a separate concept, Amos' patch seems to make sense. Cheers, Rusty.