From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37478) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TF3Ti-0002Eq-2M for qemu-devel@nongnu.org; Fri, 21 Sep 2012 09:41:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TF3Ta-0005sA-UA for qemu-devel@nongnu.org; Fri, 21 Sep 2012 09:41:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21486) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TF3Ta-0005rx-La for qemu-devel@nongnu.org; Fri, 21 Sep 2012 09:41:02 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8LDf1kI019286 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 21 Sep 2012 09:41:02 -0400 From: Juan Quintela In-Reply-To: <505C621C.4070903@redhat.com> (Paolo Bonzini's message of "Fri, 21 Sep 2012 14:48:28 +0200") References: <1348217255-22441-1-git-send-email-quintela@redhat.com> <1348217255-22441-33-git-send-email-quintela@redhat.com> <505C621C.4070903@redhat.com> Date: Fri, 21 Sep 2012 17:42:41 +0200 Message-ID: <87fw6b1ixa.fsf@elfo.mitica> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 32/41] savevm: unexport qemu_ftell() Reply-To: quintela@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org Paolo Bonzini wrote: > Il 21/09/2012 10:47, Juan Quintela ha scritto: >> It was unused out of savevm.c. >> >> -int64_t qemu_ftell(QEMUFile *f) >> +static int64_t qemu_ftell(QEMUFile *f) >> { >> return f->buf_offset - f->buf_size + f->buf_index; >> } >> > > static inline? Used only once, when doing one snapshot .... > Reviewed-by: Paolo Bonzini