From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:46622)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1TCVpI-0003h9-Rx
	for qemu-devel@nongnu.org; Fri, 14 Sep 2012 09:20:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1TCVp9-0002m0-68
	for qemu-devel@nongnu.org; Fri, 14 Sep 2012 09:20:56 -0400
Received: from mail-ob0-f173.google.com ([209.85.214.173]:65463)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1TCVp9-0002lu-0E
	for qemu-devel@nongnu.org; Fri, 14 Sep 2012 09:20:47 -0400
Received: by obbta14 with SMTP id ta14so5795050obb.4
	for <qemu-devel@nongnu.org>; Fri, 14 Sep 2012 06:20:45 -0700 (PDT)
From: Anthony Liguori <anthony@codemonkey.ws>
In-Reply-To: <CAFEAcA_D=Ydd2zj1Bnd_dvj3mbaYdWqLojnzhPbpyuumfWCWTw@mail.gmail.com>
References: <20120911185615.GX6223@otherpad.lan.raisama.net>
	<1347390153-28682-1-git-send-email-ehabkost@redhat.com>
	<CABoDooN2XKUMasOqmS3OjKadi_Xp0upGm9HDJEn0uPg0cHv=2g@mail.gmail.com>
	<CAFEAcA_D=Ydd2zj1Bnd_dvj3mbaYdWqLojnzhPbpyuumfWCWTw@mail.gmail.com>
Date: Fri, 14 Sep 2012 08:20:42 -0500
Message-ID: <87fw6k4u6t.fsf@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [PATCH] configure: fix "--target-list=<target>,
	<target>, ..." option
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, Laurent Desnogues <laurent.desnogues@gmail.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org

Peter Maydell <peter.maydell@linaro.org> writes:

> On 12 September 2012 14:20, Laurent Desnogues
> <laurent.desnogues@gmail.com> wrote:
>> Sorry, I had missed this patch...
>>
>> On Tue, Sep 11, 2012 at 9:02 PM, Eduardo Habkost <ehabkost@redhat.com> wrote:
>>> commit 66d5499b3754b83c09487259c08fe2ce73188a59 broke the support for
>>> comma-separated target lists on the --target-list option. e.g.:
>>>
>>>   $ ./configure --target-list=x86_64-linux-user,x86_64-softmmu
>>>   [...]
>>>   ERROR: Target 'x86_64-linux-user,x86_64-softmmu' not recognised
>>>   $
>>>
>>> This patch restores that ability.
>>>
>>> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
>>> Cc: Daniel P. Berrange <berrange@redhat.com>
>>> Cc: Anthony Liguori <anthony@codemonkey.ws>
>>> ---
>>>  configure | 4 +++-
>>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/configure b/configure
>>> index 7656c32..9ee7038 100755
>>> --- a/configure
>>> +++ b/configure
>>> @@ -1323,7 +1323,9 @@ if ! "$python" -c 'import sys; sys.exit(sys.version_info < (2,4) or sys.version_
>>>  fi
>>>
>>>  if test "$target_list" = "DEFAULT" ; then
>>> -    target_list=`echo "$default_target_list" | sed -e 's/,/ /g'`
>>> +    target_list="$default_target_list"
>>> +else
>>> +    target_list=`echo "$target_list" | sed -e 's/,/ /g'`
>>>  fi
>>
>> This works for me too.
>>
>> But I still can't get what the original patch posted by
>> Daniel Berrange intended to do:
>>
>> $ ./configure --target-list=
>> $ make V=1
>> cat  | grep =y | sort -u > config-all-devices.mak
>>
>> And it of course hangs there.
>
> Hmm. Perhaps we should just revert 66d5499b3 and then recommit
> a working implementation later?

I think this is a good idea.

Regards,

Anthony Liguori

>
> -- PMM