From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:56279)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1T8YoR-0001K7-Qy
	for qemu-devel@nongnu.org; Mon, 03 Sep 2012 11:43:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1T8YoQ-0006hl-0S
	for qemu-devel@nongnu.org; Mon, 03 Sep 2012 11:43:43 -0400
Received: from mx1.redhat.com ([209.132.183.28]:53344)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1T8YoP-0006hf-Ns
	for qemu-devel@nongnu.org; Mon, 03 Sep 2012 11:43:41 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <5044C10D.7050600@redhat.com> (Avi Kivity's message of "Mon, 03
	Sep 2012 17:39:09 +0300")
References: <1346640974-30974-1-git-send-email-mmogilvi_qemu@miniinfo.net>
	<1346640974-30974-6-git-send-email-mmogilvi_qemu@miniinfo.net>
	<50446D11.5050904@suse.de> <5044C10D.7050600@redhat.com>
Date: Mon, 03 Sep 2012 17:42:25 +0200
Message-ID: <87fw6z5d0e.fsf@elfo.mitica>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v4 5/5] i8259: fix dynamically masking
	slave IRQs with IMR register
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>, Jan Kiszka <jan.kiszka@web.de>, Andreas =?utf-8?Q?F=C3=A4rber?= <afaerber@suse.de>, Matthew Ogilvie <mmogilvi_qemu@miniinfo.net>

Avi Kivity <avi@redhat.com> wrote:
> On 09/03/2012 11:40 AM, Andreas F=C3=A4rber wrote:
>> Am 03.09.2012 04:56, schrieb Matthew Ogilvie:
>>> diff --git a/hw/i8259_common.c b/hw/i8259_common.c
>>> index ab3d98b..dcde5f2 100644
>>> --- a/hw/i8259_common.c
>>> +++ b/hw/i8259_common.c
>> [...]
>>> @@ -111,6 +112,7 @@ static const VMStateDescription vmstate_pic_common =
=3D {
>>>          VMSTATE_UINT8(isr, PICCommonState),
>>>          VMSTATE_UINT8(priority_add, PICCommonState),
>>>          VMSTATE_UINT8(irq_base, PICCommonState),
>>> +        VMSTATE_UINT8(icw3, PICCommonState),
>>>          VMSTATE_UINT8(read_reg_select, PICCommonState),
>>>          VMSTATE_UINT8(poll, PICCommonState),
>>>          VMSTATE_UINT8(special_mask, PICCommonState),
>>=20
>> Additional VMState needs to be versioned by incrementing .version_id and
>> by specifying the new version number here. Otherwise it breaks migration.

For the subsection, only sending this when icw3 !=3D 0 is enough?  I am
searching for a test about when we need to send it.

> And incrementing the version ID breaks backwards migration.  The correct
> solution is subsections, copying Juan and booking a trip to the Mariana
> trench.

Book also for me, no need for the return ticket.

Later, Juan.