From mboxrd@z Thu Jan 1 00:00:00 1970 From: ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org (Eric W. Biederman) Subject: Re: Network namespace and bonding WARNING at fs/proc/generic.c remove_proc_entry Date: Fri, 06 Jul 2012 11:57:09 -0700 Message-ID: <87fw94g1kq.fsf@xmission.com> References: <1340900320.3441.88.camel@pro6455b.example.com> <20120705220749.GA11255@mail.hallyn.com> <87ehopu3e5.fsf@xmission.com> <20120706170538.GA31679@mail.hallyn.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120706170538.GA31679-7LNsyQBKDXoIagZqoN9o3w@public.gmane.org> (Serge E. Hallyn's message of "Fri, 6 Jul 2012 17:05:38 +0000") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: "Serge E. Hallyn" Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Dilip Daya , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: containers.vger.kernel.org "Serge E. Hallyn" writes: >> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c >> index 2ee8cf9..818ed64 100644 >> --- a/drivers/net/bonding/bond_main.c >> +++ b/drivers/net/bonding/bond_main.c >> @@ -4345,6 +4345,9 @@ static void bond_setup(struct net_device *bond_dev) >> bond_dev->priv_flags |= IFF_BONDING; >> bond_dev->priv_flags &= ~(IFF_XMIT_DST_RELEASE | IFF_TX_SKB_SHARING); >> >> + /* Don't allow bond devices to change network namespaces. */ >> + bond_dev->features |= NETIF_F_LOCAL; > > I believe this needs to be NETIF_F_NETNS_LOCAL. Test build still going with > that change. Yes that is what I mean. Eric From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932610Ab2GFS5T (ORCPT ); Fri, 6 Jul 2012 14:57:19 -0400 Received: from out01.mta.xmission.com ([166.70.13.231]:48759 "EHLO out01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757610Ab2GFS5R (ORCPT ); Fri, 6 Jul 2012 14:57:17 -0400 From: ebiederm@xmission.com (Eric W. Biederman) To: "Serge E. Hallyn" Cc: Dilip Daya , linux-kernel@vger.kernel.org, containers@lists.linux-foundation.org, netdev@vger.kernel.org References: <1340900320.3441.88.camel@pro6455b.example.com> <20120705220749.GA11255@mail.hallyn.com> <87ehopu3e5.fsf@xmission.com> <20120706170538.GA31679@mail.hallyn.com> Date: Fri, 06 Jul 2012 11:57:09 -0700 In-Reply-To: <20120706170538.GA31679@mail.hallyn.com> (Serge E. Hallyn's message of "Fri, 6 Jul 2012 17:05:38 +0000") Message-ID: <87fw94g1kq.fsf@xmission.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=;;;mid=;;;hst=in02.mta.xmission.com;;;ip=98.207.153.68;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX1+kI64lGztvK2dJJ066IufNTjtqOkF1454= X-SA-Exim-Connect-IP: 98.207.153.68 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.1 XMSubLong Long Subject * 0.0 T_TM2_M_HEADER_IN_MSG BODY: T_TM2_M_HEADER_IN_MSG * -0.5 BAYES_05 BODY: Bayes spam probability is 1 to 5% * [score: 0.0311] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa07 1397; Body=1 Fuz1=1 Fuz2=1] X-Spam-DCC: XMission; sa07 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ;"Serge E. Hallyn" X-Spam-Relay-Country: Subject: Re: Network namespace and bonding WARNING at fs/proc/generic.c remove_proc_entry X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Fri, 06 Aug 2010 16:31:04 -0600) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "Serge E. Hallyn" writes: >> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c >> index 2ee8cf9..818ed64 100644 >> --- a/drivers/net/bonding/bond_main.c >> +++ b/drivers/net/bonding/bond_main.c >> @@ -4345,6 +4345,9 @@ static void bond_setup(struct net_device *bond_dev) >> bond_dev->priv_flags |= IFF_BONDING; >> bond_dev->priv_flags &= ~(IFF_XMIT_DST_RELEASE | IFF_TX_SKB_SHARING); >> >> + /* Don't allow bond devices to change network namespaces. */ >> + bond_dev->features |= NETIF_F_LOCAL; > > I believe this needs to be NETIF_F_NETNS_LOCAL. Test build still going with > that change. Yes that is what I mean. Eric