Re: [Qemu-devel] [PATCH 6/7] Exit loop if we have been there too long

[Juan Quintela <quintela@redhat.com>]

Orit Wasserman <owasserm@redhat.com> wrote:
> On 05/22/2012 09:32 PM, Juan Quintela wrote:
>> cheking each 64 pages is a random magic number as good as any other.
> s/cheking/checking

Done.

>> +        */
>> +        if ((i & 63) == 0) {
>> +            uint64_t t1 = (qemu_get_clock_ns(rt_clock) - bwidth) / 1000000;
>> +            if (t1 > 50) { /* 50ms, half buffered_file limit */
> can't we use a constant ?

50 is a constant already, no?  Or what do you mean.

>> +                printf("big delay %ld milliseconds, %d iterations\n", t1, i);
> printf ? 

This is the kind of "this shouldn't happen", but still happens, DPRINTF?

Thanks, Juan.