All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] vala: do not append a -dirty suffix to the valac version number
Date: Fri, 18 May 2012 10:44:58 +0200	[thread overview]
Message-ID: <87fwaxop2t.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1337170229-29684-1-git-send-email-spdawson@gmail.com> (spdawson@gmail.com's message of "Wed, 16 May 2012 13:10:28 +0100")

>>>>> "spdawson" == spdawson  <spdawson@gmail.com> writes:

 spdawson> From: Simon Dawson <spdawson@gmail.com>
 spdawson> Signed-off-by: Simon Dawson <spdawson@gmail.com>
 spdawson> ---
 spdawson>  package/vala/vala-fix-dirty-version-suffix.patch |   15 +++++++++++++++
 spdawson>  1 file changed, 15 insertions(+)
 spdawson>  create mode 100644 package/vala/vala-fix-dirty-version-suffix.patch

 spdawson> diff --git a/package/vala/vala-fix-dirty-version-suffix.patch b/package/vala/vala-fix-dirty-version-suffix.patch
 spdawson> new file mode 100644
 spdawson> index 0000000..4b0044d
 spdawson> --- /dev/null
 spdawson> +++ b/package/vala/vala-fix-dirty-version-suffix.patch
 spdawson> @@ -0,0 +1,15 @@
 spdawson> +Do not append a -dirty suffix to the valac version number. The presence of
 spdawson> +the suffix can caused problems for packages (e.g. midori) which check the
 spdawson> +valac version number during configuration.

Why is this needed? We don't apply any patches to vala, and I don't see
any "-dirty" suffix in valac --version:

./output/host/usr/bin/valac --version
Vala 0.15.2

-- 
Bye, Peter Korsgaard

  parent reply	other threads:[~2012-05-18  8:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-16 12:10 [Buildroot] [PATCH 1/2] vala: do not append a -dirty suffix to the valac version number spdawson at gmail.com
2012-05-16 12:10 ` [Buildroot] [PATCH 2/2] midori: bump version to 0.4.6 spdawson at gmail.com
2012-05-18  8:44 ` Peter Korsgaard [this message]
2012-05-18 13:06   ` [Buildroot] [PATCH 1/2] vala: do not append a -dirty suffix to the valac version number Simon Dawson
2012-05-18 14:57     ` Peter Korsgaard
  -- strict thread matches above, loose matches on Subject: below --
2012-05-18 16:15 spdawson at gmail.com
2012-05-18 16:47 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fwaxop2t.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.