All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Ball <cjb@laptop.org>
To: Chuanxiao Dong <chuanxiao.dong@intel.com>
Cc: linux-mmc@vger.kernel.org, andrew@lunn.ch
Subject: Re: [PATCH]mmc: core: check PM_SLEEP for mmc_bus_suspend/resume callbacks
Date: Mon, 23 Apr 2012 08:11:47 -0400	[thread overview]
Message-ID: <87fwbufy0s.fsf@laptop.org> (raw)
In-Reply-To: <20120423071802.GA14743@intel.com> (Chuanxiao Dong's message of "Mon, 23 Apr 2012 15:18:02 +0800")

Hi,

On Mon, Apr 23 2012, Chuanxiao Dong wrote:
> If PM_SLEEP is not enabled, mmc.c will give warnning since mmc_bus_suspend/
> mmc_bus_resume functions are defined but not used. This patch can fix this
> warnning.
>
> Found-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Chuanxiao Dong <chuanxiao.dong@intel.com>
> ---
>  drivers/mmc/core/bus.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mmc/core/bus.c b/drivers/mmc/core/bus.c
> index c60cee9..9b68933 100644
> --- a/drivers/mmc/core/bus.c
> +++ b/drivers/mmc/core/bus.c
> @@ -122,6 +122,7 @@ static int mmc_bus_remove(struct device *dev)
>  	return 0;
>  }
>  
> +#ifdef CONFIG_PM_SLEEP
>  static int mmc_bus_suspend(struct device *dev)
>  {
>  	struct mmc_driver *drv = to_mmc_driver(dev->driver);
> @@ -143,6 +144,7 @@ static int mmc_bus_resume(struct device *dev)
>  		ret = drv->resume(card);
>  	return ret;
>  }
> +#endif
>  
>  #ifdef CONFIG_PM_RUNTIME

Thanks, pushed to mmc-next for 3.5.

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

      reply	other threads:[~2012-04-23 12:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-23  7:18 [PATCH]mmc: core: check PM_SLEEP for mmc_bus_suspend/resume callbacks Chuanxiao Dong
2012-04-23 12:11 ` Chris Ball [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fwbufy0s.fsf@laptop.org \
    --to=cjb@laptop.org \
    --cc=andrew@lunn.ch \
    --cc=chuanxiao.dong@intel.com \
    --cc=linux-mmc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.