Re: [PATCH v1 1/1] mmc: core: fix power class selection

[Chris Ball <cjb@laptop.org>]

Hi,

On Tue, Apr 03 2012, Namjae Jeon wrote:
> 2012/4/3 Girish K S <girish.shivananjappa@linaro.org>:
>> On 3 April 2012 15:55, Subhash Jadavani <subhashj@codeaurora.org> wrote:
>>> mmc_select_powerclass() function returns error if eMMC
>>> VDD level supported by host is between 2.7v to 3.2v.
>>>
>>> According to eMMC specification, valid voltage for high
>>> voltage cards is 2.7v to 3.6v. This patch ensures that
>>> 2.7v to 3.6v VDD range is treated as valid range.
>>>
>>> Also, failure to set the power class shouldn't be treated
>>> as fatal error because even if setting the power class
>>> fails, card can still work in default power class.
>>> If mmc_select_powerclass() returns error, just print
>>> the warning message and go ahead with rest of the card
>>> initialization.
>>>
>>> Signed-off-by: Subhash Jadavani <subhashj@codeaurora.org>
>> looks good to me
>> Acked By:  Girish K S <girish.shivananjappa@linaro.org>
>
> I double checked with specification. this patch make good sense.
> Reviewed-by: Namjae Jeon <linkinjeon@gmail.com>

Thanks, pushed to mmc-next for 3.4.

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child