All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@sunsite.dk>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] source: print messages when all sources downloaded
Date: Wed, 13 Jul 2011 20:42:05 +0200	[thread overview]
Message-ID: <87fwmadnuq.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <201107132011.51230.yann.morin.1998@anciens.enib.fr> (Yann E. MORIN's message of "Wed, 13 Jul 2011 20:11:50 +0200")

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@anciens.enib.fr> writes:

Hi,

 Yann> Indeed. We could print the message only if DL_MODE==DOWNLOAD. Would that
 Yann> be OK with you?

We could, but I'm not really sure if we should. We don't do anything
like that for any of the other make targets.

 Yann> Incidentally, external-deps and source-check will not be really complete
 Yann> when crostool-NG is the backend, as there is no way to ask such a thing
 Yann> to crosstool-NG.

Ok, also not by playing games with a replacement wget/curl/whatever that
just prints basename $1 or similar?

 Yann> Note that source-check is currently borked due to some unconfigured
 Yann> defconfig files for bootloaders and kernel. Eg. for barebox:
 Yann>   $ make -C ../br.upstream O=$(pwd) source-check
 Yann>   [--SNIP-]
 Yann>   make O=/home/ymorin/dev/buildroot/O _source-check
 Yann>   make[1]: Entering directory `/home/ymorin/dev/buildroot/br.upstream'
 Yann>   boot/barebox/barebox.mk:60: *** No Barebox defconfig file. Check your
 Yann>   BR2_TARGET_BAREBOX_BOARD_DEFCONFIG setting.  Stop.
 Yann>   make[1]: Leaving directory `/home/ymorin/dev/buildroot/br.upstream'
 Yann>   make: *** [source-check] Error 2
 Yann>   make: Leaving directory `/home/ymorin/dev/buildroot/br.upstream'

Yes, we currently require a buildable .config for make
source/source-check/external-deps, which I don't really think is big
issue for normal use cases. I do hit it when I update the
sources.buildroot.net mirror using make allyesconfig && make source, so
we could try to get rid of that restriction if it doesn't make the
linux/barebox/uboot Makefiles too ugly.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2011-07-13 18:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-12 23:07 [Buildroot] [PATCH 0/2] Allow only downloading sources with crosstool-NG backend Yann E. MORIN
2011-07-12 23:07 ` [Buildroot] [PATCH 1/2] toolchain/crosstool-ng: allow pre-downloading the sources Yann E. MORIN
2011-07-13  6:36   ` Peter Korsgaard
2011-07-12 23:07 ` [Buildroot] [PATCH 2/2] source: print messages when all sources downloaded Yann E. MORIN
2011-07-13  6:37   ` Peter Korsgaard
2011-07-13 18:11     ` Yann E. MORIN
2011-07-13 18:42       ` Peter Korsgaard [this message]
2011-07-13 20:46         ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fwmadnuq.fsf@macbook.be.48ers.dk \
    --to=jacmet@sunsite.dk \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.