From: Kevin Hilman <khilman@deeprootsystems.com>
To: Nishanth Menon <nm@ti.com>
Cc: linux-omap <linux-omap@vger.kernel.org>,
Benoit <b-cousson@ti.com>, Tony <tony@atomide.com>,
Thomas <thomas.petazzoni@free-electrons.com>
Subject: Re: [PATCH v5 0/3] OMAP: Add opp data
Date: Wed, 08 Dec 2010 15:42:19 -0800 [thread overview]
Message-ID: <87fwu7esro.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1290617647-3604-1-git-send-email-nm@ti.com> (Nishanth Menon's message of "Wed, 24 Nov 2010 10:54:04 -0600")
Hi Nishanth,
Nishanth Menon <nm@ti.com> writes:
> Major changes in V5:
> rebased to k.org 2.6.37-rc3
> introduced omap_opp_data.h
> couple of whitespace and offline license suggestion cleanups
OK, v5 looks good to me. One more minor minor detail. Can you post
one more time with linux-arm-kernel in Cc so it doesn't have to be
reposted before Tony merges it. Please also add in Paul's ack on patch
3. Thanks.
Unless there are other objections, I'll pull the next rev into my
pm-next and queue for 2.6.38.
Note that as we go further with DVFS, we will likely need to expand this
OPP data/table to include some more options, but that can be done when
the time comes, so I'm OK with the current form for now.
Thanks Nishanth,
Kevin
> V4: http://marc.info/?l=linux-omap&m=128993367112637&w=2
> V3: http://marc.info/?l=linux-omap&m=128984926812800&w=2
> V2: http://marc.info/?t=128753665300003&r=1&w=2
>
> Kevin Hilman (1):
> OMAP3: remove OPP interfaces from OMAP PM layer
>
> Nishanth Menon (2):
> omap: opp: add OMAP3 OPP table data and common init
> omap4: opp: add OPP table data
>
> Documentation/arm/OMAP/omap_pm | 25 +++++++
> arch/arm/mach-omap2/Kconfig | 4 +
> arch/arm/mach-omap2/Makefile | 6 ++
> arch/arm/mach-omap2/io.c | 3 +-
> arch/arm/mach-omap2/omap_opp_data.h | 72 +++++++++++++++++++
> arch/arm/mach-omap2/opp.c | 93 +++++++++++++++++++++++++
> arch/arm/mach-omap2/opp3xxx_data.c | 107 +++++++++++++++++++++++++++++
> arch/arm/mach-omap2/opp4xxx_data.c | 57 +++++++++++++++
> arch/arm/mach-omap2/pm.h | 14 ++++
> arch/arm/plat-omap/include/plat/omap-pm.h | 31 +++------
> arch/arm/plat-omap/omap-pm-noop.c | 11 +---
> 11 files changed, 390 insertions(+), 33 deletions(-)
> create mode 100644 arch/arm/mach-omap2/omap_opp_data.h
> create mode 100644 arch/arm/mach-omap2/opp.c
> create mode 100644 arch/arm/mach-omap2/opp3xxx_data.c
> create mode 100644 arch/arm/mach-omap2/opp4xxx_data.c
>
> Bloat-o-meter report for omap2plus_defconfig Vs 2.6.37-rc3:
> add/remove: 22/3 grow/shrink: 4/3 up/down: 3149/-64 (3085)
> function old new delta
> opp_add - 568 +568
> opp_set_availability - 520 +520
> omap_init_opp_table - 328 +328
> omap34xx_opp_def_list - 208 +208
> static.__func__ 13783 13954 +171
> opp_find_freq_floor - 164 +164
> omap36xx_opp_def_list - 160 +160
> opp_find_freq_ceil - 144 +144
> opp_find_freq_exact - 128 +128
> find_device_opp - 124 +124
> opp_get_opp_count - 120 +120
> omap44xx_opp_def_list - 96 +96
> opp_get_voltage - 76 +76
> opp_get_freq - 76 +76
> omap3_opp_init - 76 +76
> dev_opp_list_lock - 72 +72
> omap4_opp_init - 48 +48
> vermagic 45 60 +15
> linux_banner 133 148 +15
> opp_enable - 8 +8
> opp_disable - 8 +8
> dev_opp_list - 8 +8
> kernel_config_data 13899 13906 +7
> __initcall_omap4_opp_init6 - 4 +4
> __initcall_omap3_opp_init6 - 4 +4
> omap_table_init - 1 +1
> omap_pm_cpu_set_freq 28 24 -4
> mpu_opps 4 - -4
> l3_opps 4 - -4
> dsp_opps 4 - -4
> omap_pm_if_early_init 20 8 -12
> omap2_init_common_hw 464 428 -36
>
> Regards,
> Nishanth Menon
prev parent reply other threads:[~2010-12-08 23:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-24 16:54 [PATCH v5 0/3] OMAP: Add opp data Nishanth Menon
2010-11-24 16:54 ` [PATCH v5 1/3] omap: opp: add OMAP3 OPP table data and common init Nishanth Menon
2010-11-24 16:54 ` [PATCH v5 2/3] omap4: opp: add OPP table data Nishanth Menon
2010-11-24 16:54 ` [PATCH v3 3/3] OMAP3: remove OPP interfaces from OMAP PM layer Nishanth Menon
2010-11-25 2:08 ` Paul Walmsley
2010-12-08 23:05 ` [PATCH v5 0/3] OMAP: Add opp data Menon, Nishanth
2010-12-08 23:42 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fwu7esro.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=b-cousson@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.