All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@deeprootsystems.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
	"Rafael J. Wysocki" <rjw@sisk.pl>, Nishanth Menon <nm@ti.com>,
	linux-pm@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org,
	patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] PM: Hide OPP configuration when SoCs do not provide an implementation
Date: Tue, 09 Nov 2010 11:17:50 -0800	[thread overview]
Message-ID: <87fwvaqpb5.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1289327056-27950-1-git-send-email-broonie@opensource.wolfsonmicro.com> (Mark Brown's message of "Tue, 9 Nov 2010 18:24:16 +0000")

Mark Brown <broonie@opensource.wolfsonmicro.com> writes:

> Since the OPP API is only useful with an appropraite SoC-specific
> implementation there is no point in offering the ability to enable
> the API on general systems. Provide an ARCH_HAS OPP Kconfig symbol
> which masks out the option unless selected by an implementation.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

Acked-by: Kevin Hilman <khilman@deeprootsystems.com>

> ---
>  Documentation/power/opp.txt |    3 +++
>  kernel/power/Kconfig        |    4 ++++
>  2 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/Documentation/power/opp.txt b/Documentation/power/opp.txt
> index 44d87ad..cd44558 100644
> --- a/Documentation/power/opp.txt
> +++ b/Documentation/power/opp.txt
> @@ -37,6 +37,9 @@ Typical usage of the OPP library is as follows:
>  SoC framework	-> modifies on required cases certain OPPs	-> OPP layer
>  		-> queries to search/retrieve information	->
>  
> +Architectures that provide a SoC framework for OPP should select ARCH_HAS_OPP
> +to make the OPP layer available.
> +
>  OPP layer expects each domain to be represented by a unique device pointer. SoC
>  framework registers a set of initial OPPs per device with the OPP layer. This
>  list is expected to be an optimally small number typically around 5 per device.
> diff --git a/kernel/power/Kconfig b/kernel/power/Kconfig
> index 29bff61..a5aff3e 100644
> --- a/kernel/power/Kconfig
> +++ b/kernel/power/Kconfig
> @@ -246,9 +246,13 @@ config PM_OPS
>  	depends on PM_SLEEP || PM_RUNTIME
>  	default y
>  
> +config ARCH_HAS_OPP
> +	bool
> +
>  config PM_OPP
>  	bool "Operating Performance Point (OPP) Layer library"
>  	depends on PM
> +	depends on ARCH_HAS_OPP
>  	---help---
>  	  SOCs have a standard set of tuples consisting of frequency and
>  	  voltage pairs that the device will support per voltage domain. This

  parent reply	other threads:[~2010-11-09 19:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-09 18:24 [PATCH] PM: Hide OPP configuration when SoCs do not provide an implementation Mark Brown
2010-11-09 19:04 ` Nishanth Menon
2010-11-09 19:04   ` Nishanth Menon
2010-11-09 19:17 ` Kevin Hilman [this message]
2010-11-11  0:52   ` Rafael J. Wysocki
2010-11-11  0:52   ` Rafael J. Wysocki
2010-11-09 19:17 ` Kevin Hilman
  -- strict thread matches above, loose matches on Subject: below --
2010-11-09 18:24 Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fwvaqpb5.fsf@deeprootsystems.com \
    --to=khilman@deeprootsystems.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=nm@ti.com \
    --cc=patches@opensource.wolfsonmicro.com \
    --cc=pavel@ucw.cz \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.