From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=54615 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P3Zx7-0002f5-Gj for qemu-devel@nongnu.org; Wed, 06 Oct 2010 15:47:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P3Zx6-0007qP-CC for qemu-devel@nongnu.org; Wed, 06 Oct 2010 15:47:01 -0400 Received: from mailout-de.gmx.net ([213.165.64.23]:60459 helo=mail.gmx.net) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1P3Zx6-0007po-0d for qemu-devel@nongnu.org; Wed, 06 Oct 2010 15:47:00 -0400 From: xscript@gmx.net (=?utf-8?Q?Llu=C3=ADs?=) Date: Wed, 06 Oct 2010 21:44:41 +0200 Message-ID: <87fwwj14ye.fsf@ginnungagap.bsc.es> MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] Load primitive in linux-user/signal.c List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org I'm still not very tuned-in into the code, but I think this piece should use _raw access primitives: diff --git a/linux-user/signal.c b/linux-user/signal.c index 77683f7..097da9d 100644 --- a/linux-user/signal.c +++ b/linux-user/signal.c @@ -982,8 +982,8 @@ restore_sigcontext(CPUX86State *env, struct target_sigcontext *sc, int *peax) env->regs[R_ECX] = tswapl(sc->ecx); env->eip = tswapl(sc->eip); - cpu_x86_load_seg(env, R_CS, lduw(&sc->cs) | 3); - cpu_x86_load_seg(env, R_SS, lduw(&sc->ss) | 3); + cpu_x86_load_seg(env, R_CS, lduw_raw(&sc->cs) | 3); + cpu_x86_load_seg(env, R_SS, lduw_raw(&sc->ss) | 3); tmpflags = tswapl(sc->eflags); env->eflags = (env->eflags & ~0x40DD5) | (tmpflags & 0x40DD5); I triggered it while capturing "lduw" and the like in both softmmu and linux-user to intercept memory access information coming from non-generated code (I'm not capturing neither _raw nor _code, as they do not seem to relate to "real" memory access events on the guest). What I've found is that this is the only place where a ld* primitive is not being passed a "target_ulong" as argument. Thanks, Lluis -- "And it's much the same thing with knowledge, for whenever you learn something new, the whole world becomes that much richer." -- The Princess of Pure Reason, as told by Norton Juster in The Phantom Tollbooth