From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH v2] OMAP2PLUS: WDT: Fix: Disable WDT after reset during init Date: Tue, 05 Oct 2010 09:35:08 -0700 Message-ID: <87fwwktx6r.fsf@deeprootsystems.com> References: <1286015771-22041-1-git-send-email-charu@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pw0-f46.google.com ([209.85.160.46]:46586 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751872Ab0JEQfP (ORCPT ); Tue, 5 Oct 2010 12:35:15 -0400 In-Reply-To: <1286015771-22041-1-git-send-email-charu@ti.com> (Charulatha Varadarajan's message of "Sat, 2 Oct 2010 16:06:11 +0530") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Varadarajan, Charulatha" Cc: tony@atomide.com, wim@iguana.be, linux-omap@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, paul@pwsan.com, b-cousson@ti.com, rnayak@ti.com, santosh.shilimkar@ti.com, p-basak2@ti.com "Varadarajan, Charulatha" writes: > Inorder to avoid any assumptions from bootloader, the watchdog > timer module is reset during init. This enables the watchdog > timer. > > Therefore, it is required to disable WDT after it is reset > during init. Otherwise the system would reboot as per the default > watchdog timer registers settings. > > Later, when the watchdog driver is loaded, the watchdog timer settings > is adjusted as per the default timer_margin set in the driver and the > driver would supports the normal operations supported by OMAP watchdog > timer. > > Link to related discussions: > https://patchwork.kernel.org/patch/219072/ > > Issue reported by Kevin can be found at: > https://patchwork.kernel.org/patch/217262/ > > Signed-off-by: Charulatha V > Reported-by: Kevin Hilman Acked-by: Kevin Hilman Tony, this should queue up for .37 on top of my pm-hwmods branch. It applies cleanly to current l-o master. Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pw0-f46.google.com ([209.85.160.46]:46586 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751872Ab0JEQfP (ORCPT ); Tue, 5 Oct 2010 12:35:15 -0400 From: Kevin Hilman To: "Varadarajan\, Charulatha" Cc: tony@atomide.com, wim@iguana.be, linux-omap@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, paul@pwsan.com, b-cousson@ti.com, rnayak@ti.com, santosh.shilimkar@ti.com, p-basak2@ti.com Subject: Re: [PATCH v2] OMAP2PLUS: WDT: Fix: Disable WDT after reset during init References: <1286015771-22041-1-git-send-email-charu@ti.com> Date: Tue, 05 Oct 2010 09:35:08 -0700 In-Reply-To: <1286015771-22041-1-git-send-email-charu@ti.com> (Charulatha Varadarajan's message of "Sat, 2 Oct 2010 16:06:11 +0530") Message-ID: <87fwwktx6r.fsf@deeprootsystems.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org "Varadarajan, Charulatha" writes: > Inorder to avoid any assumptions from bootloader, the watchdog > timer module is reset during init. This enables the watchdog > timer. > > Therefore, it is required to disable WDT after it is reset > during init. Otherwise the system would reboot as per the default > watchdog timer registers settings. > > Later, when the watchdog driver is loaded, the watchdog timer settings > is adjusted as per the default timer_margin set in the driver and the > driver would supports the normal operations supported by OMAP watchdog > timer. > > Link to related discussions: > https://patchwork.kernel.org/patch/219072/ > > Issue reported by Kevin can be found at: > https://patchwork.kernel.org/patch/217262/ > > Signed-off-by: Charulatha V > Reported-by: Kevin Hilman Acked-by: Kevin Hilman Tony, this should queue up for .37 on top of my pm-hwmods branch. It applies cleanly to current l-o master. Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@deeprootsystems.com (Kevin Hilman) Date: Tue, 05 Oct 2010 09:35:08 -0700 Subject: [PATCH v2] OMAP2PLUS: WDT: Fix: Disable WDT after reset during init In-Reply-To: <1286015771-22041-1-git-send-email-charu@ti.com> (Charulatha Varadarajan's message of "Sat, 2 Oct 2010 16:06:11 +0530") References: <1286015771-22041-1-git-send-email-charu@ti.com> Message-ID: <87fwwktx6r.fsf@deeprootsystems.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org "Varadarajan, Charulatha" writes: > Inorder to avoid any assumptions from bootloader, the watchdog > timer module is reset during init. This enables the watchdog > timer. > > Therefore, it is required to disable WDT after it is reset > during init. Otherwise the system would reboot as per the default > watchdog timer registers settings. > > Later, when the watchdog driver is loaded, the watchdog timer settings > is adjusted as per the default timer_margin set in the driver and the > driver would supports the normal operations supported by OMAP watchdog > timer. > > Link to related discussions: > https://patchwork.kernel.org/patch/219072/ > > Issue reported by Kevin can be found at: > https://patchwork.kernel.org/patch/217262/ > > Signed-off-by: Charulatha V > Reported-by: Kevin Hilman Acked-by: Kevin Hilman Tony, this should queue up for .37 on top of my pm-hwmods branch. It applies cleanly to current l-o master. Kevin