From: Eric Anholt <eric@anholt.net>
To: Dan Carpenter <error27@gmail.com>, David Airlie <airlied@linux.ie>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
Chris Wilson <chris@chris-wilson.co.uk>,
Zhenyu Wang <zhenyuw@linux.intel.com>,
nanhai.zou@intel.com, Benny Halevy <bhalevy@panasas.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [patch] i915: take struct_mutex in i915_dma_cleanup()
Date: Thu, 01 Jul 2010 15:39:57 -0700 [thread overview]
Message-ID: <87fx0225du.fsf@pollan.anholt.net> (raw)
In-Reply-To: <20100623111954.GA16433@bicker>
[-- Attachment #1: Type: text/plain, Size: 863 bytes --]
On Wed, 23 Jun 2010 13:19:55 +0200, Dan Carpenter <error27@gmail.com> wrote:
> intel_cleanup_ring_buffer() calls drm_gem_object_unreference() (as
> opposed to drm_gem_object_unreference_unlocked()) so it needs to be
> called with "struct_mutex" held. If we don't hold the lock, it triggers
> a BUG_ON(!mutex_is_locked(&dev->struct_mutex));
>
> I also audited the other places that call intel_cleanup_ring_buffer()
> and they all hold the lock so they're OK.
>
> This was introduced in: 8187a2b70e3 "drm/i915: introduce
> intel_ring_buffer structure (V2)" and it's a regression from v2.6.34.
>
> Addresses: https://bugzilla.kernel.org/show_bug.cgi?id=16247
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> Reported-by: Benny Halevy <bhalevy@panasas.com>
> Tested-by: Benny Halevy <bhalevy@panasas.com>
Applied to for-linus. Thanks!
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
prev parent reply other threads:[~2010-07-01 22:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-23 11:19 [patch] i915: take struct_mutex in i915_dma_cleanup() Dan Carpenter
2010-06-23 15:47 ` Jesse Barnes
2010-07-25 15:05 ` Chris Wilson
2010-07-01 22:39 ` Eric Anholt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fx0225du.fsf@pollan.anholt.net \
--to=eric@anholt.net \
--cc=airlied@linux.ie \
--cc=bhalevy@panasas.com \
--cc=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=error27@gmail.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nanhai.zou@intel.com \
--cc=zhenyuw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.