From: Kalle Valo <kalle.valo@iki.fi>
To: "tom.leiming\@gmail.com" <tom.leiming@gmail.com>
Cc: "linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>,
"johannes\@sipsolutions.net" <johannes@sipsolutions.net>
Subject: Re: [PATCH] mac80211: fix memory leak in ieee80211_send_probe_req
Date: Fri, 15 Jan 2010 16:19:03 +0200 [thread overview]
Message-ID: <87fx67qwmg.fsf@nokia.com> (raw)
In-Reply-To: <1263563061-3825-1-git-send-email-tom.leiming@gmail.com> (ext tom's message of "Fri, 15 Jan 2010 14:44:21 +0100")
"ext tom.leiming@gmail.com" <tom.leiming@gmail.com> writes:
> From: Ming Lei <tom.leiming@gmail.com>
>
> This patch fixes memory leak in ieee80211_send_probe_req, which
> is introduced in 7c12ce8b854df346388ea56d684784e3484012cf:
>
> mac80211: use Probe Request template when sending a direct scan
Sorry, I introduced this bug. Thank you finding this.
> The patch is against the latest wireless-test tree.
You should add comments like this after the "---" line.
> @@ -1028,6 +1028,7 @@ void ieee80211_send_probe_req(struct ieee80211_sub_if_data *sdata, u8 *dst,
>
> IEEE80211_SKB_CB(skb)->flags |= IEEE80211_TX_INTFL_DONT_ENCRYPT;
> ieee80211_tx_skb(sdata, skb);
> + kfree(buf);
Better to use dev_kfree_skb() here.
Can you resend, please?
--
Kalle Valo
next prev parent reply other threads:[~2010-01-15 14:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-15 13:44 [PATCH] mac80211: fix memory leak in ieee80211_send_probe_req tom.leiming
2010-01-15 14:19 ` Kalle Valo [this message]
2010-01-15 14:36 ` Ming Lei
2010-01-15 14:53 ` Kalle Valo
2010-01-15 14:36 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fx67qwmg.fsf@nokia.com \
--to=kalle.valo@iki.fi \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.