From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MqZAf-0007CN-40 for qemu-devel@nongnu.org; Wed, 23 Sep 2009 17:14:41 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MqZAZ-00078s-80 for qemu-devel@nongnu.org; Wed, 23 Sep 2009 17:14:39 -0400 Received: from [199.232.76.173] (port=54998 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MqZAY-00078O-DP for qemu-devel@nongnu.org; Wed, 23 Sep 2009 17:14:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39444) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MqZAX-0005Q3-Sa for qemu-devel@nongnu.org; Wed, 23 Sep 2009 17:14:34 -0400 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8NLEXZN018463 for ; Wed, 23 Sep 2009 17:14:33 -0400 Subject: Re: [Qemu-devel] [PATCH 4/5] serial: convert isa to qdev References: <1253620402-18682-1-git-send-email-kraxel@redhat.com> <1253620402-18682-5-git-send-email-kraxel@redhat.com> From: Markus Armbruster Date: Wed, 23 Sep 2009 22:42:01 +0200 In-Reply-To: <1253620402-18682-5-git-send-email-kraxel@redhat.com> (Gerd Hoffmann's message of "Tue\, 22 Sep 2009 13\:53\:21 +0200") Message-ID: <87fxadbdgm.fsf@pike.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org Gerd Hoffmann writes: > Everything using standard isa I/O ports and IRQ windup is considerd > being an actual isa device. That are all serial_init() users except > mips_mipssim() which seems to have a non-standard IRQ windup. > > baud rate is fixed at 115200 now as no caller passed in something else. > > Signed-off-by: Gerd Hoffmann > --- > hw/mips_malta.c | 4 +- > hw/mips_r4k.c | 6 +--- > hw/pc.c | 6 +--- > hw/pc.h | 1 + > hw/ppc_prep.c | 3 +- > hw/serial.c | 77 +++++++++++++++++++++++++++++++++++++++++++++++------- > hw/sun4u.c | 6 +--- > 7 files changed, 75 insertions(+), 28 deletions(-) > [...] > diff --git a/hw/ppc_prep.c b/hw/ppc_prep.c > index cb7167e..889284a 100644 > --- a/hw/ppc_prep.c > +++ b/hw/ppc_prep.c > @@ -685,7 +685,8 @@ static void ppc_prep_init (ram_addr_t ram_size, > // pit = pit_init(0x40, i8259[0]); > rtc_init(2000); > > - serial_init(0x3f8, i8259[4], 115200, serial_hds[0]); > + if (serial_hds[0]) > + serial_isa_init(0, serial_hds[0]); > nb_nics1 = nb_nics; > if (nb_nics1 > NE2000_NB_MAX) > nb_nics1 = NE2000_NB_MAX; Why the new conditional? Bug fix perhaps? [...]