From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MW8PU-0005Oi-GO for qemu-devel@nongnu.org; Wed, 29 Jul 2009 08:37:32 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MW8PO-0005M1-Mt for qemu-devel@nongnu.org; Wed, 29 Jul 2009 08:37:31 -0400 Received: from [199.232.76.173] (port=37990 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MW8PN-0005LI-AN for qemu-devel@nongnu.org; Wed, 29 Jul 2009 08:37:25 -0400 Received: from canardo.mork.no ([148.122.252.1]:39138) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MW8PM-0007tc-4w for qemu-devel@nongnu.org; Wed, 29 Jul 2009 08:37:24 -0400 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= Subject: Re: [Qemu-devel] [PATCH] alsa broken when the host is suspended (or hibernated) References: <1248864666-31387-1-git-send-email-bjorn@mork.no> Date: Wed, 29 Jul 2009 14:36:01 +0200 In-Reply-To: (malc's message of "Wed, 29 Jul 2009 15:57:15 +0400 (MSD)") Message-ID: <87fxcf64zy.fsf@nemi.mork.no> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: malc Cc: qemu-devel@nongnu.org malc writes: > Thank you. I've massaged the patch a bit: > > a. Trimmed the comment line to fit 80 columns > b. Suppressed tabs Thanks. Guess I should have read the qemu coding standard first... Shame on me. > c. Added -ESTRPIPE handling to alsa_run_in > d. Changed the verbose message to indicate which of the streams > is being resumed (input/output) > > It would be very nice if you could verify that it still works since > my machine is not capable of suspending nor hibernating, it would be > very informative if you could run audio capture inside the guest to > verify c. and d. Oh, didn't event think about sending audio the other way. I must admit that I'm quite new to using audio in QEMU. I tried your modified patch with Windows XP as a client, using the Windows "Sound Recorder" app for testing audio capture. I have it working up until the host is suspended, but cannot make it work after resuming. Nothing is captured and nothing is logged to the QEMU monitor. The "Sound Recorder" app just sits there after pressing record, without ever changing the stream position from 0,00 sec. Resuming audio output of course still works fine with your modifications: (qemu) alsa: Resuming suspended output stream But audio capture still don't work, even if output is resumed. > The tree is at: > http://repo.or.cz/w/qemu/malc.git?a=3Dshortlog;h=3Drefs/heads/alsa > > Or you can just apply first commit's patch. > > [..snip..] > > P.S. Perhaps you could also come up with a better subject line? I suspect that my suggestions will be affected by my limited view of the world :-) I'm not sure what you do have in mind, but how about=20 "alsa: add host resume support" ? But I guess we'll have to fix the audio capture part before making such claims. Bj=C3=B8rn