All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kalle.valo@iki.fi>
To: Michael Buesch <mb@bu3sch.de>
Cc: Jaswinder Singh Rajput <jaswinder@kernel.org>,
	Sujith <Sujith.Manoharan@atheros.com>,
	wireless <linux-wireless@vger.kernel.org>,
	David Miller <davem@davemloft.net>,
	LKML <linux-kernel@vger.kernel.org>,
	linville@tuxdriver.com
Subject: Re: ath9k becon loss messages
Date: Sun, 05 Apr 2009 13:03:54 +0300	[thread overview]
Message-ID: <87fxgnifhx.fsf@litku.valot.fi> (raw)
In-Reply-To: <200904051136.15285.mb@bu3sch.de> (Michael Buesch's message of "Sun\, 5 Apr 2009 11\:36\:15 +0200")

Michael Buesch <mb@bu3sch.de> writes:

> On Sunday 05 April 2009 11:29:38 Michael Buesch wrote:
>
>> I think this message should only show if
>> CONFIG_MAC80211_VERBOSE_DEBUG is set. It's kind of expected that we
>> lose a beacon once in a while, so we shouldn't print verbose
>> messages to the kernel log (even if they are KERN_DEBUG).
>> 
>> And besides that, I think one can easily remotely trigger this
>> message and flood the logs. So it should probably _also_ be
>> ratelimited.
>
> Something like this:

I agree, the message confuses the users and creates way too much
problems. Your patch is a good solution, the message is still useful
for the driver developers.

> Signed-off-by: Michael Buesch <mb@bu3sch.de>

Reviewed-by: Kalle Valo <kalle.valo@iki.fi>

-- 
Kalle Valo

  reply	other threads:[~2009-04-05 10:03 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-05  9:23 ath9k becon loss messages Jaswinder Singh Rajput
2009-04-05  9:29 ` Michael Buesch
2009-04-05  9:36   ` Michael Buesch
2009-04-05 10:03     ` Kalle Valo [this message]
2009-04-05 11:00     ` Jaswinder Singh Rajput
2009-04-05  9:52   ` Jaswinder Singh Rajput
2009-04-05 10:13     ` Kalle Valo
2009-04-06  7:14       ` Helmut Schaa
2009-04-06  8:17         ` Kalle Valo
2009-04-06  8:56           ` Helmut Schaa
2009-04-06  9:04             ` Kalle Valo
2009-04-06 10:17         ` Michael Buesch
2009-04-06 10:23           ` Kalle Valo
2009-04-06 10:51             ` Helmut Schaa
2009-04-06 11:05               ` Kalle Valo
2009-04-06 11:05                 ` Kalle Valo
2009-04-06 15:18                 ` Kalle Valo
2009-04-06 18:00                   ` John W. Linville
2009-04-07  5:54                     ` Kalle Valo
2009-04-07 13:53                       ` John W. Linville
2009-04-07 15:19                         ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fxgnifhx.fsf@litku.valot.fi \
    --to=kalle.valo@iki.fi \
    --cc=Sujith.Manoharan@atheros.com \
    --cc=davem@davemloft.net \
    --cc=jaswinder@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=mb@bu3sch.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.