From: Andi Kleen <andi@firstfloor.org>
To: Peter W Morreale <pmorreale@novell.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] pdflush fix and enhancement
Date: Wed, 31 Dec 2008 01:28:46 +0100 [thread overview]
Message-ID: <87fxk5ur0h.fsf@basil.nowhere.org> (raw)
In-Reply-To: <20081230231152.10427.50620.stgit@hermosa.site> (Peter W. Morreale's message of "Tue, 30 Dec 2008 16:12:29 -0700")
Peter W Morreale <pmorreale@novell.com> writes:
> The following series implements a fix for pdflush thread creation and an
> enhancement for allowing the setting of the minimum and maximun number
> of pdflush threads.
You forgot to state why the admin should control that?
Each sysctl essentially presents a failure of the automatic tuning
algorithms of the kernel (kernel hackers admitting defeat).
So a patch adding new ones at least needs a clear rationale what
problem it is trying to fix and why the automatic tuning cannot be
fixed instead to address this case without new knobs.
-Andi
--
ak@linux.intel.com
next prev parent reply other threads:[~2008-12-31 0:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-30 23:12 [PATCH 0/2] pdflush fix and enhancement Peter W Morreale
2008-12-30 23:12 ` [PATCH 1/2] Fix pdflush thread creation upper bound Peter W Morreale
2008-12-30 23:12 ` [PATCH 2/2] Add /proc controls for pdflush threads Peter W Morreale
2008-12-30 23:59 ` Randy Dunlap
2008-12-31 0:15 ` Peter W. Morreale
2008-12-31 2:38 ` Peter W. Morreale
2008-12-31 3:30 ` Randy Dunlap
2008-12-31 8:01 ` Andrew Morton
2008-12-31 14:54 ` Peter W. Morreale
2008-12-31 0:28 ` Andi Kleen [this message]
2008-12-31 1:56 ` [PATCH 0/2] pdflush fix and enhancement Peter W. Morreale
2008-12-31 2:46 ` Andi Kleen
2008-12-31 4:11 ` Peter W. Morreale
2008-12-31 7:08 ` Dave Chinner
2008-12-31 15:40 ` Peter W. Morreale
2009-01-01 23:27 ` Dave Chinner
2009-01-02 2:07 ` Peter W. Morreale
2008-12-31 13:27 ` Andi Kleen
2008-12-31 16:08 ` Peter W. Morreale
2009-01-01 1:48 ` Andi Kleen
2008-12-31 11:40 ` Martin Knoblauch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fxk5ur0h.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmorreale@novell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.