From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] svn commit: trunk/buildroot/package/make
Date: Wed, 05 Nov 2008 09:31:51 +0100 [thread overview]
Message-ID: <87fxm6zi88.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20081105080930.8D6EE3C808@busybox.net> (egtvedt@uclibc.org's message of "Wed\, 5 Nov 2008 00\:09\:30 -0800 \(PST\)")
>>>>> "egtvedt" == egtvedt <egtvedt@uclibc.org> writes:
egtvedt> Author: egtvedt
egtvedt> Date: 2008-11-05 00:09:30 -0800 (Wed, 05 Nov 2008)
egtvedt> New Revision: 23928
egtvedt> Log:
egtvedt> make: select gettext and libintl if locale is enabled
egtvedt> ifeq ($(strip $(BR2_PACKAGE_MAKE)),y)
egtvedt> -TARGETS+=make
egtvedt> +TARGETS+=$(if $(BR2_PACKAGE_GETTEXT),gettext) make
We normally do this by adding it as a dependency to the make: target,
E.G.:
make: uclibc $(if $(BR2_PACKAGE_GETTEXT),gettext) $(TARGET_DIR)/$(GNUMAKE_TARGET_BINARY)
Adding it to TARGETS doesn't ensure that gettext gets built before
make (well, actually it does, but it isn't very clear or robust)
Could you please change it?
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2008-11-05 8:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-05 8:09 [Buildroot] svn commit: trunk/buildroot/package/make egtvedt at uclibc.org
2008-11-05 8:31 ` Peter Korsgaard [this message]
2008-11-05 8:42 ` Hans-Christian Egtvedt
-- strict thread matches above, loose matches on Subject: below --
2008-11-05 8:43 egtvedt at uclibc.org
2007-07-31 18:40 ulf at uclibc.org
2007-07-09 18:36 aldot at uclibc.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fxm6zi88.fsf@macbook.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.